Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request - Make batch instances stoppable request work for clusters without topology setup #2893

Closed
GrantPSpencer opened this issue Aug 27, 2024 · 0 comments

Comments

@GrantPSpencer
Copy link
Contributor

Is your feature request related to a problem? Please describe.
batch stoppable check (in InstancesAccessor.java) does not work for clusters that do not have topology information set up for their instances.

#2886 (comment)

If there is no topology set up for the cluster, I believe batch stoppable will actually return an empty.
My current assumption is that this is due to the single instance stoppable check calling getZoneBasedInstances which seems will return an empty list when no topology set.
For the batch instances check, it will return empty because it relies on _orderOfZones not being empty.

the per instance stoppable check should work normally in this case.

Describe the solution you'd like
batch stoppable check should not filter out instances that do not have topology information set. One possible solution is to consider them as all the same zone.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants