[Bug] incorrect dataGroupId for old data items in universalTransition

[tyn1998]

Version

5.3.0

Link to Minimal Reproduction

https://codepen.io/tyn1998/pen/GRxpgQq

Steps to Reproduce

1. visit my codepen url above
2. click "Animals" bar (universalTransition animation works)
3. click "Back" (not works)
4. comment line 12 dataGroupId: "", and repeat 2 and 3 they both will work

Current Behavior

Hi, Echarts core team!

I have read the related source code so I know where the problem occurs.

echarts/src/animation/universalTransition.ts

Line 210 in 89d57f2

const dataGroupId = data.hostModel && (data.hostModel as SeriesModel).get('dataGroupId') as string;

When processing old data items, after executing this line, dataGroupId is wrongly assigned to a value that is belong to new data items, which is due to the factor of having notMerge default set to false when .setOption(newOption).

This bug will not be exposed when data item's groupId is specified.

Expected Behavior

Old data items should be given correct dataGroupId when item.groupId is not specified.

Environment

- OS: macOS Monterey
- Browser: Chrome 103
- Framework: None

Any additional comments?

N.A.

[tyn1998]

which is due to the factor of having notMerge default set to false when .setOption(newOption).

Can be supported by another case:

echarts/test/universalTransition2.html

Lines 482 to 492 in 7f3b2ba

	buttons: [{
	text: 'Scatter',
	onclick: function () {
	chart.setOption(scatterOption, true);
	}
	}, {
	text: 'Bar',
	onclick: function () {
	chart.setOption(barOption, true);
	}
	}],

where notMerge set to true so we can get correct dataGroupId for old data item.

[tyn1998]

Complement:

if Echarts cannot find dataGroupId in series, it will try to find it in parent model:

echarts/src/model/Model.ts

Lines 234 to 239 in 7f3b2ba

	if (obj == null && parentModel) {
	obj = parentModel._doGet(
	this.resolveParentPath(pathArr) as [string],
	parentModel.parentModel
	) as any;
	}

[tyn1998]

closed via #17559