Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] toolbox title is (still) cut by parent container #16472

Closed
zachsa opened this issue Feb 8, 2022 · 1 comment · Fixed by #16704
Closed

[Bug] toolbox title is (still) cut by parent container #16472

zachsa opened this issue Feb 8, 2022 · 1 comment · Fixed by #16704
Labels
bug en This issue is in English topic: toolbox

Comments

@zachsa
Copy link

zachsa commented Feb 8, 2022

Version

5.3.0

Link to Minimal Reproduction

https://nccrd.saeon.ac.za/reports

Steps to Reproduce

  1. Go to the URL
  2. Hover over the 'Save as image' toolbox item

Current Behavior

The toolbox item title is truncated by parent element

Expected Behavior

I expected there to be a toolbox.title.appendToBody configuration option such as is available as other parts of the API.

Environment

- OS:ALL (I think)
- Browser: Chrome
- Framework: React 17

Any additional comments?

I saw a similar issue - #10951. That has been marked as closed but as far as I can tell it is still an issue. (Or, I don't know of the configuration option to avoid this - for example, placing the title at left, right, bottom, etc. would help)

@zachsa zachsa added the bug label Feb 8, 2022
@echarts-bot echarts-bot bot added the missing-title This issue is missing a descriptive title. label Feb 8, 2022
@echarts-bot
Copy link

echarts-bot bot commented Feb 8, 2022

I'm sorry to close this issue for it lacks the necessary title. Please provide a descriptive and as concise as possible title to describe your problems or requests and then the maintainers or I will reopen this issue.

Every good bug report or feature request starts with a title. Your issue title is a critical element as it's the first thing maintainers see.

A good issue title makes it easier for maintainers to understand what the issue is, easily locate it, and know what steps they'll need to take to fix it.

Moreover, it's better to include keywords, as this makes it easier to find the issue self and similar issues in searches.

@echarts-bot echarts-bot bot closed this as completed Feb 8, 2022
@zachsa zachsa changed the title [Bug] [Bug] toolbox title is (still) cut by parent container Feb 8, 2022
@echarts-bot echarts-bot bot added en This issue is in English pending We are not sure about whether this is a bug/new feature. waiting-for: community labels Feb 8, 2022
@echarts-bot echarts-bot bot reopened this Feb 8, 2022
@echarts-bot echarts-bot bot removed the missing-title This issue is missing a descriptive title. label Feb 8, 2022
@plainheart plainheart added topic: toolbox and removed pending We are not sure about whether this is a bug/new feature. waiting-for: community labels Feb 8, 2022
@plainheart plainheart added this to the 5.4 milestone Feb 8, 2022
@plainheart plainheart removed this from the 5.4 milestone Mar 19, 2022
@plainheart plainheart linked a pull request Mar 19, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug en This issue is in English topic: toolbox
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants