Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(tooltip): improve the performance of tooltip. #14246

Merged
merged 10 commits into from
Mar 19, 2021
Merged

perf(tooltip): improve the performance of tooltip. #14246

merged 10 commits into from
Mar 19, 2021

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Feb 8, 2021 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

As mentioned in #13680, the tooltip looks delayed and has an obvious lag. This brings the users a bad interaction experience.
This PR is attempting to improve the performance of the tooltip. Any idea is welcome.

Fixed issues

Details

Before: What was the problem?

The moving of the tooltip has an obvious lag.

After: How is it fixed in this PR?

case.mp4

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

Please refer to test/new-tooltip.html or any other test cases related to tooltip.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

Related PR in zrender: ecomfe/zrender#721

@echarts-bot
Copy link

echarts-bot bot commented Feb 8, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

plainheart added a commit to ecomfe/zrender that referenced this pull request Feb 8, 2021
@plainheart
feat(env): add support for transform3dSupported & `ieTransform3dSup…
f20151e 
…ported`.

- for apache/echarts#14246
@plainheart plainheart mentioned this pull request Feb 8, 2021
Merged
@pissang
Copy link
Contributor

pissang commented Feb 8, 2021 •
edited
Loading

Wow looks really nice!

@pissang pissang added this to the 5.1.0 milestone Feb 8, 2021
@Ovilia Ovilia removed this from the 5.1.0 milestone Mar 1, 2021
@Ovilia Ovilia linked an issue Mar 1, 2021 that may be closed by this pull request
tooltip performance issue #13680
Closed
100pah
100pah requested changes Mar 15, 2021
View reviewed changes
src/component/tooltip/helper.ts Outdated Show resolved Hide resolved
src/component/tooltip/helper.ts Outdated Show resolved Hide resolved
@100pah
Copy link
Member

100pah commented Mar 15, 2021

Wonderful job.

@plainheart plainheart linked an issue Mar 16, 2021 that may be closed by this pull request
Funnel chart, tooltip, when moving between modules, there is a feeling of freezing #14204
Closed
@100pah 100pah merged commit 07b074a into master Mar 19, 2021
@echarts-bot
Copy link

echarts-bot bot commented Mar 19, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the perf-tooltip branch March 19, 2021 16:11
@scttcper scttcper mentioned this pull request Nov 23, 2021
Closed
6 tasks
@pissang pissang mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100pah 100pah 100pah approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Funnel chart, tooltip, when moving between modules, there is a feeling of freezing tooltip performance issue
4 participants
@plainheart @pissang @100pah @Ovilia