Skip to content

Commit be71bdf

Browse files
committed
remove_nullable can be called on const column
1 parent d7d0d77 commit be71bdf

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

be/src/vec/columns/column_const.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ class ColumnConst final : public COWHelper<IColumn, ColumnConst> {
185185
return false;
186186
}
187187

188-
bool is_nullable() const override { return data->is_nullable(); }
188+
// bool is_nullable() const override { return is_column_nullable(*data); }
189189
bool only_null() const override { return data->is_null_at(0); }
190190
bool is_numeric() const override { return data->is_numeric(); }
191191
bool is_fixed_and_contiguous() const override { return data->is_fixed_and_contiguous(); }

be/src/vec/exec/join/vhash_join_node.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1175,7 +1175,7 @@ void HashJoinNode::_prepare_probe_block() {
11751175
// remove add nullmap of probe columns
11761176
for (auto index : _probe_column_convert_to_null) {
11771177
auto& column_type = _probe_block.safe_get_by_position(index);
1178-
DCHECK(column_type.column->is_nullable());
1178+
DCHECK(column_type.column->is_nullable() || is_column_const(*(column_type.column.get())));
11791179
DCHECK(column_type.type->is_nullable());
11801180

11811181
column_type.column = remove_nullable(column_type.column);

0 commit comments

Comments
 (0)