From af9274448281f0fe709880ea05481fbe6615827b Mon Sep 17 00:00:00 2001 From: universalmind303 Date: Mon, 1 Apr 2024 13:24:40 -0500 Subject: [PATCH 1/2] refactor: make all udf function impls public --- datafusion/functions-array/src/array_has.rs | 6 ++--- datafusion/functions-array/src/concat.rs | 6 ++--- datafusion/functions-array/src/lib.rs | 8 +++--- datafusion/functions-array/src/udf.rs | 26 +++++++++---------- datafusion/functions/src/core/arrowtypeof.rs | 2 +- datafusion/functions/src/core/getfield.rs | 2 +- datafusion/functions/src/core/mod.rs | 12 ++++----- datafusion/functions/src/core/nullif.rs | 2 +- datafusion/functions/src/core/nvl.rs | 2 +- datafusion/functions/src/core/nvl2.rs | 2 +- datafusion/functions/src/core/struct.rs | 2 +- datafusion/functions/src/crypto/digest.rs | 2 +- datafusion/functions/src/crypto/md5.rs | 2 +- datafusion/functions/src/crypto/sha224.rs | 2 +- datafusion/functions/src/crypto/sha256.rs | 2 +- datafusion/functions/src/crypto/sha384.rs | 2 +- datafusion/functions/src/crypto/sha512.rs | 2 +- .../functions/src/datetime/current_date.rs | 2 +- .../functions/src/datetime/current_time.rs | 2 +- datafusion/functions/src/datetime/date_bin.rs | 2 +- .../functions/src/datetime/date_part.rs | 2 +- .../functions/src/datetime/date_trunc.rs | 2 +- .../functions/src/datetime/from_unixtime.rs | 2 +- datafusion/functions/src/datetime/mod.rs | 22 ++++++++-------- datafusion/functions/src/datetime/now.rs | 2 +- datafusion/functions/src/datetime/to_date.rs | 2 +- .../functions/src/datetime/to_timestamp.rs | 10 +++---- .../functions/src/datetime/to_unixtime.rs | 2 +- datafusion/functions/src/encoding/inner.rs | 4 +-- datafusion/functions/src/encoding/mod.rs | 2 +- datafusion/functions/src/math/abs.rs | 2 +- datafusion/functions/src/math/mod.rs | 4 +-- datafusion/functions/src/math/nans.rs | 2 +- datafusion/functions/src/regex/regexplike.rs | 2 +- datafusion/functions/src/regex/regexpmatch.rs | 2 +- .../functions/src/regex/regexpreplace.rs | 2 +- 36 files changed, 76 insertions(+), 76 deletions(-) diff --git a/datafusion/functions-array/src/array_has.rs b/datafusion/functions-array/src/array_has.rs index 17c0ad1619d6..d3570bf1f3e2 100644 --- a/datafusion/functions-array/src/array_has.rs +++ b/datafusion/functions-array/src/array_has.rs @@ -54,7 +54,7 @@ make_udf_function!(ArrayHasAny, ); #[derive(Debug)] -pub(super) struct ArrayHas { +pub struct ArrayHas { signature: Signature, aliases: Vec, } @@ -121,7 +121,7 @@ impl ScalarUDFImpl for ArrayHas { } #[derive(Debug)] -pub(super) struct ArrayHasAll { +pub struct ArrayHasAll { signature: Signature, aliases: Vec, } @@ -178,7 +178,7 @@ impl ScalarUDFImpl for ArrayHasAll { } #[derive(Debug)] -pub(super) struct ArrayHasAny { +pub struct ArrayHasAny { signature: Signature, aliases: Vec, } diff --git a/datafusion/functions-array/src/concat.rs b/datafusion/functions-array/src/concat.rs index a8e7d1008f46..98c2eb43618a 100644 --- a/datafusion/functions-array/src/concat.rs +++ b/datafusion/functions-array/src/concat.rs @@ -45,7 +45,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArrayAppend { +pub struct ArrayAppend { signature: Signature, aliases: Vec, } @@ -99,7 +99,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArrayPrepend { +pub struct ArrayPrepend { signature: Signature, aliases: Vec, } @@ -152,7 +152,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArrayConcat { +pub struct ArrayConcat { signature: Signature, aliases: Vec, } diff --git a/datafusion/functions-array/src/lib.rs b/datafusion/functions-array/src/lib.rs index a932e7d7a5b0..04ab385b0c21 100644 --- a/datafusion/functions-array/src/lib.rs +++ b/datafusion/functions-array/src/lib.rs @@ -28,12 +28,12 @@ #[macro_use] pub mod macros; -mod array_has; -mod concat; +pub mod array_has; +pub mod concat; mod kernels; -mod make_array; +pub mod make_array; mod rewrite; -mod udf; +pub mod udf; mod utils; use datafusion_common::Result; diff --git a/datafusion/functions-array/src/udf.rs b/datafusion/functions-array/src/udf.rs index 9fd9e0309bde..1462b3efad33 100644 --- a/datafusion/functions-array/src/udf.rs +++ b/datafusion/functions-array/src/udf.rs @@ -40,7 +40,7 @@ make_udf_function!(ArrayToString, array_to_string_udf // internal function name ); #[derive(Debug)] -pub(super) struct ArrayToString { +pub struct ArrayToString { signature: Signature, aliases: Vec, } @@ -98,7 +98,7 @@ make_udf_function!(StringToArray, string_to_array_udf // internal function name ); #[derive(Debug)] -pub(super) struct StringToArray { +pub struct StringToArray { signature: Signature, aliases: Vec, } @@ -174,7 +174,7 @@ make_udf_function!( range_udf ); #[derive(Debug)] -pub(super) struct Range { +pub struct Range { signature: Signature, aliases: Vec, } @@ -244,7 +244,7 @@ make_udf_function!( gen_series_udf ); #[derive(Debug)] -pub(super) struct GenSeries { +pub struct GenSeries { signature: Signature, aliases: Vec, } @@ -315,7 +315,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArrayDims { +pub struct ArrayDims { signature: Signature, aliases: Vec, } @@ -372,7 +372,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArraySort { +pub struct ArraySort { signature: Signature, aliases: Vec, } @@ -445,7 +445,7 @@ impl Cardinality { } #[derive(Debug)] -pub(super) struct Cardinality { +pub struct Cardinality { signature: Signature, aliases: Vec, } @@ -490,7 +490,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArrayNdims { +pub struct ArrayNdims { signature: Signature, aliases: Vec, } @@ -544,7 +544,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArrayEmpty { +pub struct ArrayEmpty { signature: Signature, aliases: Vec, } @@ -597,7 +597,7 @@ make_udf_function!( array_repeat_udf // internal function name ); #[derive(Debug)] -pub(super) struct ArrayRepeat { +pub struct ArrayRepeat { signature: Signature, aliases: Vec, } @@ -650,7 +650,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArrayLength { +pub struct ArrayLength { signature: Signature, aliases: Vec, } @@ -704,7 +704,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct Flatten { +pub struct Flatten { signature: Signature, aliases: Vec, } @@ -772,7 +772,7 @@ make_udf_function!( ); #[derive(Debug)] -pub(super) struct ArrayDistinct { +pub struct ArrayDistinct { signature: Signature, aliases: Vec, } diff --git a/datafusion/functions/src/core/arrowtypeof.rs b/datafusion/functions/src/core/arrowtypeof.rs index 89702d3267ec..69c71b622813 100644 --- a/datafusion/functions/src/core/arrowtypeof.rs +++ b/datafusion/functions/src/core/arrowtypeof.rs @@ -22,7 +22,7 @@ use datafusion_expr::{ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct ArrowTypeOfFunc { +pub struct ArrowTypeOfFunc { signature: Signature, } diff --git a/datafusion/functions/src/core/getfield.rs b/datafusion/functions/src/core/getfield.rs index 0a99cccf9e1c..252883c88e27 100644 --- a/datafusion/functions/src/core/getfield.rs +++ b/datafusion/functions/src/core/getfield.rs @@ -25,7 +25,7 @@ use datafusion_expr::{ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct GetFieldFunc { +pub struct GetFieldFunc { signature: Signature, } diff --git a/datafusion/functions/src/core/mod.rs b/datafusion/functions/src/core/mod.rs index 73cc4d18bf9f..29b333cc5b9e 100644 --- a/datafusion/functions/src/core/mod.rs +++ b/datafusion/functions/src/core/mod.rs @@ -17,12 +17,12 @@ //! "core" DataFusion functions -mod arrowtypeof; -mod getfield; -mod nullif; -mod nvl; -mod nvl2; -mod r#struct; +pub mod arrowtypeof; +pub mod getfield; +pub mod nullif; +pub mod nvl; +pub mod nvl2; +pub mod r#struct; // create UDFs make_udf_function!(nullif::NullIfFunc, NULLIF, nullif); diff --git a/datafusion/functions/src/core/nullif.rs b/datafusion/functions/src/core/nullif.rs index 1e903d7a881d..b31846a238be 100644 --- a/datafusion/functions/src/core/nullif.rs +++ b/datafusion/functions/src/core/nullif.rs @@ -27,7 +27,7 @@ use datafusion_expr::{ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct NullIfFunc { +pub struct NullIfFunc { signature: Signature, } diff --git a/datafusion/functions/src/core/nvl.rs b/datafusion/functions/src/core/nvl.rs index 76b037eb81ba..1976cbb3fb26 100644 --- a/datafusion/functions/src/core/nvl.rs +++ b/datafusion/functions/src/core/nvl.rs @@ -23,7 +23,7 @@ use datafusion_common::{internal_err, Result}; use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; #[derive(Debug)] -pub(super) struct NVLFunc { +pub struct NVLFunc { signature: Signature, aliases: Vec, } diff --git a/datafusion/functions/src/core/nvl2.rs b/datafusion/functions/src/core/nvl2.rs index a65657eaeafd..b1b5a36860f9 100644 --- a/datafusion/functions/src/core/nvl2.rs +++ b/datafusion/functions/src/core/nvl2.rs @@ -23,7 +23,7 @@ use datafusion_common::{internal_err, plan_datafusion_err, Result}; use datafusion_expr::{utils, ColumnarValue, ScalarUDFImpl, Signature, Volatility}; #[derive(Debug)] -pub(super) struct NVL2Func { +pub struct NVL2Func { signature: Signature, } diff --git a/datafusion/functions/src/core/struct.rs b/datafusion/functions/src/core/struct.rs index 406e402ccd85..72113bd32a69 100644 --- a/datafusion/functions/src/core/struct.rs +++ b/datafusion/functions/src/core/struct.rs @@ -61,7 +61,7 @@ fn struct_expr(args: &[ColumnarValue]) -> Result { Ok(ColumnarValue::Array(array_struct(arrays.as_slice())?)) } #[derive(Debug)] -pub(super) struct StructFunc { +pub struct StructFunc { signature: Signature, } diff --git a/datafusion/functions/src/crypto/digest.rs b/datafusion/functions/src/crypto/digest.rs index c6556787cb9c..94d37df6f9c6 100644 --- a/datafusion/functions/src/crypto/digest.rs +++ b/datafusion/functions/src/crypto/digest.rs @@ -25,7 +25,7 @@ use datafusion_expr::{ use std::any::Any; #[derive(Debug)] -pub(super) struct DigestFunc { +pub struct DigestFunc { signature: Signature, } impl DigestFunc { diff --git a/datafusion/functions/src/crypto/md5.rs b/datafusion/functions/src/crypto/md5.rs index 7b2936a37938..8801a12cd78c 100644 --- a/datafusion/functions/src/crypto/md5.rs +++ b/datafusion/functions/src/crypto/md5.rs @@ -23,7 +23,7 @@ use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct Md5Func { +pub struct Md5Func { signature: Signature, } impl Md5Func { diff --git a/datafusion/functions/src/crypto/sha224.rs b/datafusion/functions/src/crypto/sha224.rs index ef0fae97cfa5..faaeee9c542b 100644 --- a/datafusion/functions/src/crypto/sha224.rs +++ b/datafusion/functions/src/crypto/sha224.rs @@ -23,7 +23,7 @@ use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct SHA224Func { +pub struct SHA224Func { signature: Signature, } impl SHA224Func { diff --git a/datafusion/functions/src/crypto/sha256.rs b/datafusion/functions/src/crypto/sha256.rs index f763f925cc56..255aeeab6b39 100644 --- a/datafusion/functions/src/crypto/sha256.rs +++ b/datafusion/functions/src/crypto/sha256.rs @@ -23,7 +23,7 @@ use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct SHA256Func { +pub struct SHA256Func { signature: Signature, } impl SHA256Func { diff --git a/datafusion/functions/src/crypto/sha384.rs b/datafusion/functions/src/crypto/sha384.rs index b382d42663be..c19492050290 100644 --- a/datafusion/functions/src/crypto/sha384.rs +++ b/datafusion/functions/src/crypto/sha384.rs @@ -23,7 +23,7 @@ use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct SHA384Func { +pub struct SHA384Func { signature: Signature, } impl SHA384Func { diff --git a/datafusion/functions/src/crypto/sha512.rs b/datafusion/functions/src/crypto/sha512.rs index a852376fadd6..0f129120f9fc 100644 --- a/datafusion/functions/src/crypto/sha512.rs +++ b/datafusion/functions/src/crypto/sha512.rs @@ -23,7 +23,7 @@ use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct SHA512Func { +pub struct SHA512Func { signature: Signature, } impl SHA512Func { diff --git a/datafusion/functions/src/datetime/current_date.rs b/datafusion/functions/src/datetime/current_date.rs index 5338234a8e49..1fe880f23802 100644 --- a/datafusion/functions/src/datetime/current_date.rs +++ b/datafusion/functions/src/datetime/current_date.rs @@ -26,7 +26,7 @@ use datafusion_expr::simplify::{ExprSimplifyResult, SimplifyInfo}; use datafusion_expr::{ColumnarValue, Expr, ScalarUDFImpl, Signature, Volatility}; #[derive(Debug)] -pub(super) struct CurrentDateFunc { +pub struct CurrentDateFunc { signature: Signature, aliases: Vec, } diff --git a/datafusion/functions/src/datetime/current_time.rs b/datafusion/functions/src/datetime/current_time.rs index b8a8aa2acb53..3c209c2d6336 100644 --- a/datafusion/functions/src/datetime/current_time.rs +++ b/datafusion/functions/src/datetime/current_time.rs @@ -26,7 +26,7 @@ use datafusion_expr::simplify::{ExprSimplifyResult, SimplifyInfo}; use datafusion_expr::{ColumnarValue, Expr, ScalarUDFImpl, Signature, Volatility}; #[derive(Debug)] -pub(super) struct CurrentTimeFunc { +pub struct CurrentTimeFunc { signature: Signature, } diff --git a/datafusion/functions/src/datetime/date_bin.rs b/datafusion/functions/src/datetime/date_bin.rs index 8472c346f183..9513afcf7a02 100644 --- a/datafusion/functions/src/datetime/date_bin.rs +++ b/datafusion/functions/src/datetime/date_bin.rs @@ -40,7 +40,7 @@ use datafusion_expr::{ }; #[derive(Debug)] -pub(super) struct DateBinFunc { +pub struct DateBinFunc { signature: Signature, } diff --git a/datafusion/functions/src/datetime/date_part.rs b/datafusion/functions/src/datetime/date_part.rs index 200dcff6d46e..09241db8d550 100644 --- a/datafusion/functions/src/datetime/date_part.rs +++ b/datafusion/functions/src/datetime/date_part.rs @@ -38,7 +38,7 @@ use datafusion_expr::{ }; #[derive(Debug)] -pub(super) struct DatePartFunc { +pub struct DatePartFunc { signature: Signature, aliases: Vec, } diff --git a/datafusion/functions/src/datetime/date_trunc.rs b/datafusion/functions/src/datetime/date_trunc.rs index 307510712686..6db8d2ead2ba 100644 --- a/datafusion/functions/src/datetime/date_trunc.rs +++ b/datafusion/functions/src/datetime/date_trunc.rs @@ -45,7 +45,7 @@ use datafusion_expr::{ }; #[derive(Debug)] -pub(super) struct DateTruncFunc { +pub struct DateTruncFunc { signature: Signature, aliases: Vec, } diff --git a/datafusion/functions/src/datetime/from_unixtime.rs b/datafusion/functions/src/datetime/from_unixtime.rs index f0d5016c0db9..99d06097972f 100644 --- a/datafusion/functions/src/datetime/from_unixtime.rs +++ b/datafusion/functions/src/datetime/from_unixtime.rs @@ -25,7 +25,7 @@ use datafusion_common::{exec_err, Result}; use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; #[derive(Debug)] -pub(super) struct FromUnixtimeFunc { +pub struct FromUnixtimeFunc { signature: Signature, } diff --git a/datafusion/functions/src/datetime/mod.rs b/datafusion/functions/src/datetime/mod.rs index 4702820782c6..783ddcf5a08d 100644 --- a/datafusion/functions/src/datetime/mod.rs +++ b/datafusion/functions/src/datetime/mod.rs @@ -21,17 +21,17 @@ use std::sync::Arc; use datafusion_expr::ScalarUDF; -mod common; -mod current_date; -mod current_time; -mod date_bin; -mod date_part; -mod date_trunc; -mod from_unixtime; -mod now; -mod to_date; -mod to_timestamp; -mod to_unixtime; +pub mod common; +pub mod current_date; +pub mod current_time; +pub mod date_bin; +pub mod date_part; +pub mod date_trunc; +pub mod from_unixtime; +pub mod now; +pub mod to_date; +pub mod to_timestamp; +pub mod to_unixtime; // create UDFs make_udf_function!(current_date::CurrentDateFunc, CURRENT_DATE, current_date); diff --git a/datafusion/functions/src/datetime/now.rs b/datafusion/functions/src/datetime/now.rs index cc7979df0d86..e20802597664 100644 --- a/datafusion/functions/src/datetime/now.rs +++ b/datafusion/functions/src/datetime/now.rs @@ -26,7 +26,7 @@ use datafusion_expr::simplify::{ExprSimplifyResult, SimplifyInfo}; use datafusion_expr::{ColumnarValue, Expr, ScalarUDFImpl, Signature, Volatility}; #[derive(Debug)] -pub(super) struct NowFunc { +pub struct NowFunc { signature: Signature, } diff --git a/datafusion/functions/src/datetime/to_date.rs b/datafusion/functions/src/datetime/to_date.rs index 3756566d4204..afd0b92a0297 100644 --- a/datafusion/functions/src/datetime/to_date.rs +++ b/datafusion/functions/src/datetime/to_date.rs @@ -26,7 +26,7 @@ use datafusion_common::{exec_err, internal_datafusion_err, Result}; use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; #[derive(Debug)] -pub(super) struct ToDateFunc { +pub struct ToDateFunc { signature: Signature, } diff --git a/datafusion/functions/src/datetime/to_timestamp.rs b/datafusion/functions/src/datetime/to_timestamp.rs index 2eb21c5cdaec..2e998aa07bb9 100644 --- a/datafusion/functions/src/datetime/to_timestamp.rs +++ b/datafusion/functions/src/datetime/to_timestamp.rs @@ -30,27 +30,27 @@ use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; use crate::datetime::common::*; #[derive(Debug)] -pub(super) struct ToTimestampFunc { +pub struct ToTimestampFunc { signature: Signature, } #[derive(Debug)] -pub(super) struct ToTimestampSecondsFunc { +pub struct ToTimestampSecondsFunc { signature: Signature, } #[derive(Debug)] -pub(super) struct ToTimestampMillisFunc { +pub struct ToTimestampMillisFunc { signature: Signature, } #[derive(Debug)] -pub(super) struct ToTimestampMicrosFunc { +pub struct ToTimestampMicrosFunc { signature: Signature, } #[derive(Debug)] -pub(super) struct ToTimestampNanosFunc { +pub struct ToTimestampNanosFunc { signature: Signature, } diff --git a/datafusion/functions/src/datetime/to_unixtime.rs b/datafusion/functions/src/datetime/to_unixtime.rs index ed56cdf8d0af..98a2f1be1196 100644 --- a/datafusion/functions/src/datetime/to_unixtime.rs +++ b/datafusion/functions/src/datetime/to_unixtime.rs @@ -26,7 +26,7 @@ use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility}; use super::to_timestamp::ToTimestampSecondsFunc; #[derive(Debug)] -pub(super) struct ToUnixtimeFunc { +pub struct ToUnixtimeFunc { signature: Signature, } diff --git a/datafusion/functions/src/encoding/inner.rs b/datafusion/functions/src/encoding/inner.rs index a49a64228d2f..4d7da1f450d1 100644 --- a/datafusion/functions/src/encoding/inner.rs +++ b/datafusion/functions/src/encoding/inner.rs @@ -37,7 +37,7 @@ use datafusion_expr::{ScalarUDFImpl, Signature, Volatility}; use std::any::Any; #[derive(Debug)] -pub(super) struct EncodeFunc { +pub struct EncodeFunc { signature: Signature, } @@ -91,7 +91,7 @@ impl ScalarUDFImpl for EncodeFunc { } #[derive(Debug)] -pub(super) struct DecodeFunc { +pub struct DecodeFunc { signature: Signature, } diff --git a/datafusion/functions/src/encoding/mod.rs b/datafusion/functions/src/encoding/mod.rs index 9d9f07dff7ce..49f914a68774 100644 --- a/datafusion/functions/src/encoding/mod.rs +++ b/datafusion/functions/src/encoding/mod.rs @@ -15,7 +15,7 @@ // specific language governing permissions and limitations // under the License. -mod inner; +pub mod inner; // create `encode` and `decode` UDFs make_udf_function!(inner::EncodeFunc, ENCODE, encode); diff --git a/datafusion/functions/src/math/abs.rs b/datafusion/functions/src/math/abs.rs index 8aa48460ff69..2757e954cc59 100644 --- a/datafusion/functions/src/math/abs.rs +++ b/datafusion/functions/src/math/abs.rs @@ -104,7 +104,7 @@ fn create_abs_function(input_data_type: &DataType) -> Result } } #[derive(Debug)] -pub(super) struct AbsFunc { +pub struct AbsFunc { signature: Signature, } diff --git a/datafusion/functions/src/math/mod.rs b/datafusion/functions/src/math/mod.rs index 27deb7d68427..bad2c56c2f2f 100644 --- a/datafusion/functions/src/math/mod.rs +++ b/datafusion/functions/src/math/mod.rs @@ -17,8 +17,8 @@ //! "math" DataFusion functions -mod abs; -mod nans; +pub mod abs; +pub mod nans; // Create UDFs make_udf_function!(nans::IsNanFunc, ISNAN, isnan); diff --git a/datafusion/functions/src/math/nans.rs b/datafusion/functions/src/math/nans.rs index 3f3d7d197c33..d63bfcd1070e 100644 --- a/datafusion/functions/src/math/nans.rs +++ b/datafusion/functions/src/math/nans.rs @@ -28,7 +28,7 @@ use std::any::Any; use std::sync::Arc; #[derive(Debug)] -pub(super) struct IsNanFunc { +pub struct IsNanFunc { signature: Signature, } diff --git a/datafusion/functions/src/regex/regexplike.rs b/datafusion/functions/src/regex/regexplike.rs index b0abad318058..c9b51344fcff 100644 --- a/datafusion/functions/src/regex/regexplike.rs +++ b/datafusion/functions/src/regex/regexplike.rs @@ -32,7 +32,7 @@ use std::any::Any; use std::sync::Arc; #[derive(Debug)] -pub(super) struct RegexpLikeFunc { +pub struct RegexpLikeFunc { signature: Signature, } impl RegexpLikeFunc { diff --git a/datafusion/functions/src/regex/regexpmatch.rs b/datafusion/functions/src/regex/regexpmatch.rs index f34502af35b7..1769ac58b1ce 100644 --- a/datafusion/functions/src/regex/regexpmatch.rs +++ b/datafusion/functions/src/regex/regexpmatch.rs @@ -33,7 +33,7 @@ use std::any::Any; use std::sync::Arc; #[derive(Debug)] -pub(super) struct RegexpMatchFunc { +pub struct RegexpMatchFunc { signature: Signature, } impl RegexpMatchFunc { diff --git a/datafusion/functions/src/regex/regexpreplace.rs b/datafusion/functions/src/regex/regexpreplace.rs index d90996e04b3f..b7c31160173d 100644 --- a/datafusion/functions/src/regex/regexpreplace.rs +++ b/datafusion/functions/src/regex/regexpreplace.rs @@ -38,7 +38,7 @@ use std::collections::HashMap; use std::sync::Arc; use std::sync::OnceLock; #[derive(Debug)] -pub(super) struct RegexpReplaceFunc { +pub struct RegexpReplaceFunc { signature: Signature, } impl RegexpReplaceFunc { From b7489b348cbe346dc69882e3ad3225d0d18f2b51 Mon Sep 17 00:00:00 2001 From: universalmind303 Date: Mon, 1 Apr 2024 14:04:41 -0500 Subject: [PATCH 2/2] clippy --- datafusion/functions-array/src/array_has.rs | 18 +++++++++++ datafusion/functions-array/src/concat.rs | 18 +++++++++++ datafusion/functions-array/src/make_array.rs | 6 ++++ datafusion/functions/src/core/arrow_cast.rs | 6 ++++ datafusion/functions/src/core/arrowtypeof.rs | 6 ++++ datafusion/functions/src/core/getfield.rs | 6 ++++ datafusion/functions/src/core/named_struct.rs | 6 ++++ datafusion/functions/src/core/nullif.rs | 6 ++++ datafusion/functions/src/core/nvl.rs | 6 ++++ datafusion/functions/src/core/nvl2.rs | 6 ++++ datafusion/functions/src/core/struct.rs | 6 ++++ datafusion/functions/src/crypto/digest.rs | 6 ++++ datafusion/functions/src/crypto/md5.rs | 6 ++++ datafusion/functions/src/crypto/sha224.rs | 6 ++++ datafusion/functions/src/crypto/sha256.rs | 6 ++++ datafusion/functions/src/crypto/sha384.rs | 6 ++++ datafusion/functions/src/crypto/sha512.rs | 6 ++++ .../functions/src/datetime/current_date.rs | 6 ++++ .../functions/src/datetime/current_time.rs | 6 ++++ datafusion/functions/src/datetime/date_bin.rs | 6 ++++ .../functions/src/datetime/date_part.rs | 6 ++++ .../functions/src/datetime/date_trunc.rs | 6 ++++ .../functions/src/datetime/from_unixtime.rs | 6 ++++ .../functions/src/datetime/make_date.rs | 6 ++++ datafusion/functions/src/datetime/now.rs | 6 ++++ datafusion/functions/src/datetime/to_char.rs | 6 ++++ datafusion/functions/src/datetime/to_date.rs | 6 ++++ .../functions/src/datetime/to_timestamp.rs | 30 +++++++++++++++++++ .../functions/src/datetime/to_unixtime.rs | 6 ++++ datafusion/functions/src/encoding/inner.rs | 12 ++++++++ datafusion/functions/src/math/abs.rs | 6 ++++ datafusion/functions/src/math/nans.rs | 6 ++++ datafusion/functions/src/regex/regexplike.rs | 6 ++++ datafusion/functions/src/regex/regexpmatch.rs | 6 ++++ .../functions/src/regex/regexpreplace.rs | 6 ++++ 35 files changed, 264 insertions(+) diff --git a/datafusion/functions-array/src/array_has.rs b/datafusion/functions-array/src/array_has.rs index 65d2a38e20ec..ee064335c1cc 100644 --- a/datafusion/functions-array/src/array_has.rs +++ b/datafusion/functions-array/src/array_has.rs @@ -59,6 +59,12 @@ pub struct ArrayHas { aliases: Vec, } +impl Default for ArrayHas { + fn default() -> Self { + Self::new() + } +} + impl ArrayHas { pub fn new() -> Self { Self { @@ -126,6 +132,12 @@ pub struct ArrayHasAll { aliases: Vec, } +impl Default for ArrayHasAll { + fn default() -> Self { + Self::new() + } +} + impl ArrayHasAll { pub fn new() -> Self { Self { @@ -183,6 +195,12 @@ pub struct ArrayHasAny { aliases: Vec, } +impl Default for ArrayHasAny { + fn default() -> Self { + Self::new() + } +} + impl ArrayHasAny { pub fn new() -> Self { Self { diff --git a/datafusion/functions-array/src/concat.rs b/datafusion/functions-array/src/concat.rs index 805868e5cb07..f9d9bf4356ff 100644 --- a/datafusion/functions-array/src/concat.rs +++ b/datafusion/functions-array/src/concat.rs @@ -50,6 +50,12 @@ pub struct ArrayAppend { aliases: Vec, } +impl Default for ArrayAppend { + fn default() -> Self { + Self::new() + } +} + impl ArrayAppend { pub fn new() -> Self { Self { @@ -104,6 +110,12 @@ pub struct ArrayPrepend { aliases: Vec, } +impl Default for ArrayPrepend { + fn default() -> Self { + Self::new() + } +} + impl ArrayPrepend { pub fn new() -> Self { Self { @@ -157,6 +169,12 @@ pub struct ArrayConcat { aliases: Vec, } +impl Default for ArrayConcat { + fn default() -> Self { + Self::new() + } +} + impl ArrayConcat { pub fn new() -> Self { Self { diff --git a/datafusion/functions-array/src/make_array.rs b/datafusion/functions-array/src/make_array.rs index 8eaae09f28f5..0439a736ee42 100644 --- a/datafusion/functions-array/src/make_array.rs +++ b/datafusion/functions-array/src/make_array.rs @@ -48,6 +48,12 @@ pub struct MakeArray { aliases: Vec, } +impl Default for MakeArray { + fn default() -> Self { + Self::new() + } +} + impl MakeArray { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/core/arrow_cast.rs b/datafusion/functions/src/core/arrow_cast.rs index 1195d1b4ab0e..d641389e0ae3 100644 --- a/datafusion/functions/src/core/arrow_cast.rs +++ b/datafusion/functions/src/core/arrow_cast.rs @@ -55,6 +55,12 @@ pub struct ArrowCastFunc { signature: Signature, } +impl Default for ArrowCastFunc { + fn default() -> Self { + Self::new() + } +} + impl ArrowCastFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/core/arrowtypeof.rs b/datafusion/functions/src/core/arrowtypeof.rs index 69c71b622813..cc5e7e619bd8 100644 --- a/datafusion/functions/src/core/arrowtypeof.rs +++ b/datafusion/functions/src/core/arrowtypeof.rs @@ -26,6 +26,12 @@ pub struct ArrowTypeOfFunc { signature: Signature, } +impl Default for ArrowTypeOfFunc { + fn default() -> Self { + Self::new() + } +} + impl ArrowTypeOfFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/core/getfield.rs b/datafusion/functions/src/core/getfield.rs index cde8d117f408..b00b8ea553f2 100644 --- a/datafusion/functions/src/core/getfield.rs +++ b/datafusion/functions/src/core/getfield.rs @@ -29,6 +29,12 @@ pub struct GetFieldFunc { signature: Signature, } +impl Default for GetFieldFunc { + fn default() -> Self { + Self::new() + } +} + impl GetFieldFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/core/named_struct.rs b/datafusion/functions/src/core/named_struct.rs index 01e2b9774974..8ccda977f3a4 100644 --- a/datafusion/functions/src/core/named_struct.rs +++ b/datafusion/functions/src/core/named_struct.rs @@ -78,6 +78,12 @@ pub struct NamedStructFunc { signature: Signature, } +impl Default for NamedStructFunc { + fn default() -> Self { + Self::new() + } +} + impl NamedStructFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/core/nullif.rs b/datafusion/functions/src/core/nullif.rs index b31846a238be..dc9696bd8d72 100644 --- a/datafusion/functions/src/core/nullif.rs +++ b/datafusion/functions/src/core/nullif.rs @@ -50,6 +50,12 @@ static SUPPORTED_NULLIF_TYPES: &[DataType] = &[ DataType::LargeUtf8, ]; +impl Default for NullIfFunc { + fn default() -> Self { + Self::new() + } +} + impl NullIfFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/core/nvl.rs b/datafusion/functions/src/core/nvl.rs index 1976cbb3fb26..274e36fbdecc 100644 --- a/datafusion/functions/src/core/nvl.rs +++ b/datafusion/functions/src/core/nvl.rs @@ -47,6 +47,12 @@ static SUPPORTED_NVL_TYPES: &[DataType] = &[ DataType::LargeUtf8, ]; +impl Default for NVLFunc { + fn default() -> Self { + Self::new() + } +} + impl NVLFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/core/nvl2.rs b/datafusion/functions/src/core/nvl2.rs index b1b5a36860f9..66b9ef566a78 100644 --- a/datafusion/functions/src/core/nvl2.rs +++ b/datafusion/functions/src/core/nvl2.rs @@ -27,6 +27,12 @@ pub struct NVL2Func { signature: Signature, } +impl Default for NVL2Func { + fn default() -> Self { + Self::new() + } +} + impl NVL2Func { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/core/struct.rs b/datafusion/functions/src/core/struct.rs index 817cdf92d7b2..9d4b2e4a0b8b 100644 --- a/datafusion/functions/src/core/struct.rs +++ b/datafusion/functions/src/core/struct.rs @@ -58,6 +58,12 @@ pub struct StructFunc { signature: Signature, } +impl Default for StructFunc { + fn default() -> Self { + Self::new() + } +} + impl StructFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/crypto/digest.rs b/datafusion/functions/src/crypto/digest.rs index 94d37df6f9c6..c9dd3c1f56a2 100644 --- a/datafusion/functions/src/crypto/digest.rs +++ b/datafusion/functions/src/crypto/digest.rs @@ -28,6 +28,12 @@ use std::any::Any; pub struct DigestFunc { signature: Signature, } +impl Default for DigestFunc { + fn default() -> Self { + Self::new() + } +} + impl DigestFunc { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/crypto/md5.rs b/datafusion/functions/src/crypto/md5.rs index 8801a12cd78c..ccb6fbba80aa 100644 --- a/datafusion/functions/src/crypto/md5.rs +++ b/datafusion/functions/src/crypto/md5.rs @@ -26,6 +26,12 @@ use std::any::Any; pub struct Md5Func { signature: Signature, } +impl Default for Md5Func { + fn default() -> Self { + Self::new() + } +} + impl Md5Func { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/crypto/sha224.rs b/datafusion/functions/src/crypto/sha224.rs index faaeee9c542b..2795c4a25004 100644 --- a/datafusion/functions/src/crypto/sha224.rs +++ b/datafusion/functions/src/crypto/sha224.rs @@ -26,6 +26,12 @@ use std::any::Any; pub struct SHA224Func { signature: Signature, } +impl Default for SHA224Func { + fn default() -> Self { + Self::new() + } +} + impl SHA224Func { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/crypto/sha256.rs b/datafusion/functions/src/crypto/sha256.rs index 255aeeab6b39..0a3f3b26e431 100644 --- a/datafusion/functions/src/crypto/sha256.rs +++ b/datafusion/functions/src/crypto/sha256.rs @@ -26,6 +26,12 @@ use std::any::Any; pub struct SHA256Func { signature: Signature, } +impl Default for SHA256Func { + fn default() -> Self { + Self::new() + } +} + impl SHA256Func { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/crypto/sha384.rs b/datafusion/functions/src/crypto/sha384.rs index c19492050290..c3f7845ce7bd 100644 --- a/datafusion/functions/src/crypto/sha384.rs +++ b/datafusion/functions/src/crypto/sha384.rs @@ -26,6 +26,12 @@ use std::any::Any; pub struct SHA384Func { signature: Signature, } +impl Default for SHA384Func { + fn default() -> Self { + Self::new() + } +} + impl SHA384Func { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/crypto/sha512.rs b/datafusion/functions/src/crypto/sha512.rs index 0f129120f9fc..dc3bfac9d8bd 100644 --- a/datafusion/functions/src/crypto/sha512.rs +++ b/datafusion/functions/src/crypto/sha512.rs @@ -26,6 +26,12 @@ use std::any::Any; pub struct SHA512Func { signature: Signature, } +impl Default for SHA512Func { + fn default() -> Self { + Self::new() + } +} + impl SHA512Func { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/datetime/current_date.rs b/datafusion/functions/src/datetime/current_date.rs index 1fe880f23802..8b180ff41b91 100644 --- a/datafusion/functions/src/datetime/current_date.rs +++ b/datafusion/functions/src/datetime/current_date.rs @@ -31,6 +31,12 @@ pub struct CurrentDateFunc { aliases: Vec, } +impl Default for CurrentDateFunc { + fn default() -> Self { + Self::new() + } +} + impl CurrentDateFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/current_time.rs b/datafusion/functions/src/datetime/current_time.rs index 3c209c2d6336..803759d4e904 100644 --- a/datafusion/functions/src/datetime/current_time.rs +++ b/datafusion/functions/src/datetime/current_time.rs @@ -30,6 +30,12 @@ pub struct CurrentTimeFunc { signature: Signature, } +impl Default for CurrentTimeFunc { + fn default() -> Self { + Self::new() + } +} + impl CurrentTimeFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/date_bin.rs b/datafusion/functions/src/datetime/date_bin.rs index 37fc13f6a14f..7f5d9bb5d921 100644 --- a/datafusion/functions/src/datetime/date_bin.rs +++ b/datafusion/functions/src/datetime/date_bin.rs @@ -44,6 +44,12 @@ pub struct DateBinFunc { signature: Signature, } +impl Default for DateBinFunc { + fn default() -> Self { + Self::new() + } +} + impl DateBinFunc { pub fn new() -> Self { let base_sig = |array_type: TimeUnit| { diff --git a/datafusion/functions/src/datetime/date_part.rs b/datafusion/functions/src/datetime/date_part.rs index 362e8d8713d3..111cdabe2bfb 100644 --- a/datafusion/functions/src/datetime/date_part.rs +++ b/datafusion/functions/src/datetime/date_part.rs @@ -44,6 +44,12 @@ pub struct DatePartFunc { aliases: Vec, } +impl Default for DatePartFunc { + fn default() -> Self { + Self::new() + } +} + impl DatePartFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/date_trunc.rs b/datafusion/functions/src/datetime/date_trunc.rs index d54129953f51..0414bf9c2a26 100644 --- a/datafusion/functions/src/datetime/date_trunc.rs +++ b/datafusion/functions/src/datetime/date_trunc.rs @@ -50,6 +50,12 @@ pub struct DateTruncFunc { aliases: Vec, } +impl Default for DateTruncFunc { + fn default() -> Self { + Self::new() + } +} + impl DateTruncFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/from_unixtime.rs b/datafusion/functions/src/datetime/from_unixtime.rs index 99d06097972f..d36ebe735ee7 100644 --- a/datafusion/functions/src/datetime/from_unixtime.rs +++ b/datafusion/functions/src/datetime/from_unixtime.rs @@ -29,6 +29,12 @@ pub struct FromUnixtimeFunc { signature: Signature, } +impl Default for FromUnixtimeFunc { + fn default() -> Self { + Self::new() + } +} + impl FromUnixtimeFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/make_date.rs b/datafusion/functions/src/datetime/make_date.rs index 328086356b3e..6aa72572bc4d 100644 --- a/datafusion/functions/src/datetime/make_date.rs +++ b/datafusion/functions/src/datetime/make_date.rs @@ -34,6 +34,12 @@ pub struct MakeDateFunc { signature: Signature, } +impl Default for MakeDateFunc { + fn default() -> Self { + Self::new() + } +} + impl MakeDateFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/now.rs b/datafusion/functions/src/datetime/now.rs index e20802597664..b2221215b94b 100644 --- a/datafusion/functions/src/datetime/now.rs +++ b/datafusion/functions/src/datetime/now.rs @@ -30,6 +30,12 @@ pub struct NowFunc { signature: Signature, } +impl Default for NowFunc { + fn default() -> Self { + Self::new() + } +} + impl NowFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/to_char.rs b/datafusion/functions/src/datetime/to_char.rs index f4d38beafa7e..f2e5af978ca0 100644 --- a/datafusion/functions/src/datetime/to_char.rs +++ b/datafusion/functions/src/datetime/to_char.rs @@ -40,6 +40,12 @@ pub struct ToCharFunc { aliases: Vec, } +impl Default for ToCharFunc { + fn default() -> Self { + Self::new() + } +} + impl ToCharFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/to_date.rs b/datafusion/functions/src/datetime/to_date.rs index afc80f811dec..e491c0b55508 100644 --- a/datafusion/functions/src/datetime/to_date.rs +++ b/datafusion/functions/src/datetime/to_date.rs @@ -30,6 +30,12 @@ pub struct ToDateFunc { signature: Signature, } +impl Default for ToDateFunc { + fn default() -> Self { + Self::new() + } +} + impl ToDateFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/to_timestamp.rs b/datafusion/functions/src/datetime/to_timestamp.rs index da02db6e3a45..a7bcca62944c 100644 --- a/datafusion/functions/src/datetime/to_timestamp.rs +++ b/datafusion/functions/src/datetime/to_timestamp.rs @@ -54,6 +54,12 @@ pub struct ToTimestampNanosFunc { signature: Signature, } +impl Default for ToTimestampFunc { + fn default() -> Self { + Self::new() + } +} + impl ToTimestampFunc { pub fn new() -> Self { Self { @@ -62,6 +68,12 @@ impl ToTimestampFunc { } } +impl Default for ToTimestampSecondsFunc { + fn default() -> Self { + Self::new() + } +} + impl ToTimestampSecondsFunc { pub fn new() -> Self { Self { @@ -70,6 +82,12 @@ impl ToTimestampSecondsFunc { } } +impl Default for ToTimestampMillisFunc { + fn default() -> Self { + Self::new() + } +} + impl ToTimestampMillisFunc { pub fn new() -> Self { Self { @@ -78,6 +96,12 @@ impl ToTimestampMillisFunc { } } +impl Default for ToTimestampMicrosFunc { + fn default() -> Self { + Self::new() + } +} + impl ToTimestampMicrosFunc { pub fn new() -> Self { Self { @@ -86,6 +110,12 @@ impl ToTimestampMicrosFunc { } } +impl Default for ToTimestampNanosFunc { + fn default() -> Self { + Self::new() + } +} + impl ToTimestampNanosFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/datetime/to_unixtime.rs b/datafusion/functions/src/datetime/to_unixtime.rs index 98a2f1be1196..396dadccb4b3 100644 --- a/datafusion/functions/src/datetime/to_unixtime.rs +++ b/datafusion/functions/src/datetime/to_unixtime.rs @@ -30,6 +30,12 @@ pub struct ToUnixtimeFunc { signature: Signature, } +impl Default for ToUnixtimeFunc { + fn default() -> Self { + Self::new() + } +} + impl ToUnixtimeFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/encoding/inner.rs b/datafusion/functions/src/encoding/inner.rs index 4d7da1f450d1..d9ce299a2602 100644 --- a/datafusion/functions/src/encoding/inner.rs +++ b/datafusion/functions/src/encoding/inner.rs @@ -41,6 +41,12 @@ pub struct EncodeFunc { signature: Signature, } +impl Default for EncodeFunc { + fn default() -> Self { + Self::new() + } +} + impl EncodeFunc { pub fn new() -> Self { use DataType::*; @@ -95,6 +101,12 @@ pub struct DecodeFunc { signature: Signature, } +impl Default for DecodeFunc { + fn default() -> Self { + Self::new() + } +} + impl DecodeFunc { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/math/abs.rs b/datafusion/functions/src/math/abs.rs index 2757e954cc59..e05dc8665285 100644 --- a/datafusion/functions/src/math/abs.rs +++ b/datafusion/functions/src/math/abs.rs @@ -108,6 +108,12 @@ pub struct AbsFunc { signature: Signature, } +impl Default for AbsFunc { + fn default() -> Self { + Self::new() + } +} + impl AbsFunc { pub fn new() -> Self { Self { diff --git a/datafusion/functions/src/math/nans.rs b/datafusion/functions/src/math/nans.rs index d63bfcd1070e..2bd704a7de2e 100644 --- a/datafusion/functions/src/math/nans.rs +++ b/datafusion/functions/src/math/nans.rs @@ -32,6 +32,12 @@ pub struct IsNanFunc { signature: Signature, } +impl Default for IsNanFunc { + fn default() -> Self { + Self::new() + } +} + impl IsNanFunc { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/regex/regexplike.rs b/datafusion/functions/src/regex/regexplike.rs index 9a19308215f6..09b96a28c107 100644 --- a/datafusion/functions/src/regex/regexplike.rs +++ b/datafusion/functions/src/regex/regexplike.rs @@ -35,6 +35,12 @@ use std::sync::Arc; pub struct RegexpLikeFunc { signature: Signature, } +impl Default for RegexpLikeFunc { + fn default() -> Self { + Self::new() + } +} + impl RegexpLikeFunc { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/regex/regexpmatch.rs b/datafusion/functions/src/regex/regexpmatch.rs index 4f4e2b7ff394..73228e608143 100644 --- a/datafusion/functions/src/regex/regexpmatch.rs +++ b/datafusion/functions/src/regex/regexpmatch.rs @@ -36,6 +36,12 @@ use std::sync::Arc; pub struct RegexpMatchFunc { signature: Signature, } +impl Default for RegexpMatchFunc { + fn default() -> Self { + Self::new() + } +} + impl RegexpMatchFunc { pub fn new() -> Self { use DataType::*; diff --git a/datafusion/functions/src/regex/regexpreplace.rs b/datafusion/functions/src/regex/regexpreplace.rs index b7c31160173d..4e21883c9752 100644 --- a/datafusion/functions/src/regex/regexpreplace.rs +++ b/datafusion/functions/src/regex/regexpreplace.rs @@ -41,6 +41,12 @@ use std::sync::OnceLock; pub struct RegexpReplaceFunc { signature: Signature, } +impl Default for RegexpReplaceFunc { + fn default() -> Self { + Self::new() + } +} + impl RegexpReplaceFunc { pub fn new() -> Self { use DataType::*;