Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cast between Date and Timestamp #4726

Merged
merged 3 commits into from
Dec 26, 2022
Merged

Implement cast between Date and Timestamp #4726

merged 3 commits into from
Dec 26, 2022

Conversation

comphead
Copy link
Contributor

@comphead comphead commented Dec 24, 2022 •
edited by alamb
Loading

Which issue does this PR close?

Closes #4644
Closes #4672.

Rationale for this change

Add cast between Date and Timestamp

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Physical Expressions labels Dec 24, 2022
alamb
alamb approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @comphead

datafusion/expr/src/type_coercion/binary.rs
@@ -575,6 +575,8 @@ fn temporal_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataTyp
},
(Timestamp(_, tz), Utf8) => Some(Timestamp(TimeUnit::Nanosecond, tz.clone())),
(Utf8, Timestamp(_, tz)) => Some(Timestamp(TimeUnit::Nanosecond, tz.clone())),
(Timestamp(_, _), Date32) => Some(Date32),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 01d00fd into apache:master Dec 26, 2022
@alamb
Copy link
Contributor

alamb commented Dec 26, 2022

Thanks again @comphead

@ursabot
Copy link

ursabot commented Dec 26, 2022

Benchmark runs are scheduled for baseline = a8f1f8a and contender = 01d00fd. 01d00fd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@liukun4515
Copy link
Contributor

Sorry for the late reply, I am confused about the implementation for comparing between timestamp and date type.

We have moved the type coercion logic to the logical phase in the type_coercion rule, but this feature has side affect to this.

@alamb @comphead

This was referenced Dec 27, 2022
Closed
Merged
@alamb alamb mentioned this pull request Dec 27, 2022
Merged
@alamb
Copy link
Contributor

alamb commented Dec 27, 2022

Sorry for the late reply, I am confused about the implementation for comparing between timestamp and date type.

It is an excellent point @liukun4515 -- it turns out that coercion is not necessary -- see #4745

@alamb
Copy link
Contributor

alamb commented Dec 27, 2022

Actually, it appears @liukun4515 already had a PR to do this 🤦

#4741

@comphead comphead deleted the ts_issues branch January 1, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamp <-> Date32 compare doesn't work Comparing a Timestamp to a Date32 fails
4 participants
@comphead @alamb @ursabot @liukun4515