Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoalesceBatches elasped_compute metric #4664

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Fix CoalesceBatches elasped_compute metric #4664

merged 1 commit into from
Dec 18, 2022

Conversation

Jefffrey
Copy link
Contributor

Which issue does this PR close?

Closes #3894 (and addresses part of #3494)

Rationale for this change

What changes are included in this PR?

Moving start of timer for elasped_compute to after input_batch has been polled for more accurate time

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Dec 18, 2022
alamb
alamb approved these changes Dec 18, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Jefffrey

cc @waynexia @Dandandan @NGA-TRAN

datafusion/core/src/physical_plan/coalesce_batches.rs

if self.is_closed {
return Poll::Ready(None);
}
loop {
let input_batch = self.input.poll_next_unpin(cx);
// records time on drop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 👍

@Dandandan Dandandan merged commit 9f6387e into apache:master Dec 18, 2022
@ursabot
Copy link

ursabot commented Dec 18, 2022

Benchmark runs are scheduled for baseline = acd7272 and contender = 9f6387e. 9f6387e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Dandandan
Copy link
Contributor

Thanks @Jefffrey !

@Jefffrey Jefffrey deleted the 3894_fix_coalesce_batches_metrics branch December 18, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia left review comments

@Dandandan Dandandan Dandandan approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CoalesceBatches doesn't provide correct elapsed_compute info in metrics
5 participants
@Jefffrey @ursabot @Dandandan @alamb @waynexia