Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nightly clippy happy #4515

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Make nightly clippy happy #4515

merged 2 commits into from
Dec 29, 2022

Conversation

xudong963
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate physical-expr Physical Expressions labels Dec 5, 2022
@xudong963 xudong963 marked this pull request as draft December 6, 2022 12:47
@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner sqllogictest SQL Logic Tests (.slt) labels Dec 29, 2022
@xudong963
Copy link
Member Author

TIL: cargo clippy --fix. I like it 🤣

@alamb
Copy link
Contributor

alamb commented Dec 29, 2022

TIL: cargo clippy --fix. I like it 🤣

😍

@xudong963 xudong963 marked this pull request as ready for review December 29, 2022 14:16
@xudong963 xudong963 merged commit ac876db into apache:master Dec 29, 2022
@ursabot
Copy link

ursabot commented Dec 29, 2022

Benchmark runs are scheduled for baseline = 2f9eb29 and contender = ac876db. ac876db is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan left review comments

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xudong963 @alamb @ursabot @Dandandan