Add window func related logic plan to proto ability. #4485
Conversation
Signed-off-by: yangjiang <[email protected]>
| Ok(Expr::WindowFunction { | ||
| fun: datafusion_expr::window_function::WindowFunction::BuiltInWindowFunction( | ||
| built_in_function, | ||
| ), | ||
| args: vec![parse_required_expr(&expr.expr, registry, "expr")?], |
There was a problem hiding this comment.
Unlike WindowFunction with AggrFunction like min(col). max(col). sum(col) it must have required_exp
Built-in WindowFunction like ROW_NUMBER() . RANK(). DENSE() have to have this value
|
@andygrove PATL , seems this part not have a test, have tested with ballista. |
There was a problem hiding this comment.
Code looks good to me @Ted-Jiang
can you please add a test to ensure we don't introduce regressions in the future?
Signed-off-by: yangjiang <[email protected]>
|
| let range_number_frame = WindowFrame { | ||
| units: WindowFrameUnits::Range, | ||
| start_bound: WindowFrameBound::Preceding(ScalarValue::UInt64(Some(2))), | ||
| end_bound: WindowFrameBound::Following(ScalarValue::UInt64(Some(2))), |
There was a problem hiding this comment.
without this commit, this test will fail.
Signed-off-by: yangjiang <[email protected]>
|
Benchmark runs are scheduled for baseline = 4f7b003 and contender = 34d9bb5. 34d9bb5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Signed-off-by: yangjiang [email protected]
Which issue does this PR close?
Closes #4480.
Rationale for this change
Help support window function in ballista.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?