You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
alamb
merged 2 commits into
apache:master
from
askoa:memory-underflowNov 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included a check to avoid underflow when available memory is calculated when consumers request additional memory.
The trackers acquire memory independent of MemoryManager and communicates the memory acquired using the function grow_tracker_usage. The tracker can end up allocating more memory than what is defined in MemoryManager.pool_size This PR does not prevent trackers from allocating more memory than what is defined in MemoryManager.pool_size. Might be a candidate for future refactoring.
Benchmark runs are scheduled for baseline = 0d65394 and contender = 63c81fe. 63c81fe is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4328
What changes are included in this PR?
Included a check to avoid underflow when available memory is calculated when consumers request additional memory.
The trackers acquire memory independent of
MemoryManagerand communicates the memory acquired using the functiongrow_tracker_usage. The tracker can end up allocating more memory than what is defined inMemoryManager.pool_sizeThis PR does not prevent trackers from allocating more memory than what is defined inMemoryManager.pool_size. Might be a candidate for future refactoring.Are these changes tested?
Added a test to avoid underflow.