-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove datafusion-data-access crate #2904
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2904 +/- ##
==========================================
+ Coverage 85.25% 85.27% +0.02%
==========================================
Files 277 274 -3
Lines 49371 49208 -163
==========================================
- Hits 42092 41963 -129
+ Misses 7279 7245 -34
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @yahoNanJing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it!
🎉 |
Benchmark runs are scheduled for baseline = 1b8117e and contender = 9401d6d. 9401d6d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Thank you @yahoNanJing and @xudong963 |
Which issue does this PR close?
Closes #2903.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?