fix(substrait): consuming AggregateRel as last node #12875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
approved these changes
Oct 11, 2024
| ], | ||
| "version": { | ||
| "minorNumber": 54, | ||
| "producer": "subframe" |
There was a problem hiding this comment.
Is this a publicly available producer? It's useful to know how the plans where generated, in case we ever need to regenerate them to pull in updates from the producers.
The plan itself is perfectly valid and fine as-is.
If we ever want/need to generate an equivalent plan we can use https://github.com/substrait-io/substrait-java/tree/main/isthmus-cli with a query like:
./isthmus --create "CREATE TABLE data(a INT)" "SELECT a, COUNT(*) AS c FROM data GROUP BY a"
There was a problem hiding this comment.
well, kinda.. it's a personal project. for me, it was obviously easiest to use, so I went with it, but it's far from complete, so if we want to make all files "re-generatable", we would have to use something like isthmus.
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12869.
Rationale for this change
consumer bakes in plan names into last Aggregate, but only handled metrics expressions before. This PR splits schema fields into grouping and metrics fields and renames each accordingly.
Are these changes tested?
yes
Are there any user-facing changes?
yes