Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests in expr.rs to sqllogictest #6210

Closed
Tracked by #6195
alamb opened this issue May 3, 2023 · 0 comments · Fixed by #6240
Closed
Tracked by #6195

Port tests in expr.rs to sqllogictest #6210

alamb opened this issue May 3, 2023 · 0 comments · Fixed by #6240
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented May 3, 2023

Is your feature request related to a problem or challenge?

Part of #6195. We are trying to keep the DataFusion code base clean and easy to contribute to and modify. Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily

Describe the solution you'd like

Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/expr.rs to scalar.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests/test_files

The target file already exists:
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/scalar.slt

Notes:

  1. Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests
  2. There may be some duplication when porting -- it is fine to port as is or if you want port just what is missing
  3. If you don't know how to port any particular test, please leave it in the .rs or ask on the pull request

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant