Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PruningPredicate Different Evaluation Context from Query #4693

Closed
tustvold opened this issue Dec 21, 2022 · 0 comments · Fixed by #4713
Closed

PruningPredicate Different Evaluation Context from Query #4693

tustvold opened this issue Dec 21, 2022 · 0 comments · Fixed by #4713
Labels
bug Something isn't working

Comments

@tustvold
Copy link
Contributor

Describe the bug

PruningPredicate::try_new creates its own ExecutionProps::new which captures Utc::now as the current time, this may differ from what the rest of the plan was evaluated against, yielding incorrect results

To Reproduce

Expected behavior

PruningPredicate should evaluate its expressions in the same context as normal query evaluation

Additional context

#4629 tracks making ExecutionProps a trait
#4617 is the broader issue around state mutability and inheritance
@tustvold tustvold added the bug Something isn't working label Dec 21, 2022
@tustvold tustvold changed the title PruningPredicate Incorrect now() PruningPredicate Different Evaluation Context from Query Dec 21, 2022
This was referenced Dec 21, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eagerly construct PagePruningPredicate tustvold/arrow-datafusion
1 participant
@tustvold