Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move datafusion-substrait project into arrow-datafusion repo #4536

Closed
andygrove opened this issue Dec 7, 2022 · 5 comments · Fixed by #4543
Closed

Move datafusion-substrait project into arrow-datafusion repo #4536

andygrove opened this issue Dec 7, 2022 · 5 comments · Fixed by #4543
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I would like to discuss moving the datafusion-substrait project into the main DataFusion repo.

The crate is receiving contributions from both NVIDIA and Greptimedb and is starting to have enough functionality to be useful.

It would be nice to be able to expose this to DataFusion's Python bindings as well.

Describe the solution you'd like
Move the crate into this repo. This will not impact any other DataFusion crates.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added the enhancement New feature or request label Dec 7, 2022
@andygrove andygrove changed the title Move development of substrait support into arrow-datafusion repo Move datafusion-substrait project into arrow-datafusion repo Dec 7, 2022
@andygrove
Copy link
Member Author

@waynexia @nseekhao @Dandandan fyi

@waynexia
Copy link
Member

waynexia commented Dec 7, 2022

Thanks for bringing this up @andygrove. DataFusion-Substrait is a beneficial integration to GreptimeDB. We use it to communicate logical plans between instances to achieve distributed execution. I'd like to contribute and migrate our implementation to this official one ❤️

@alamb
Copy link
Contributor

alamb commented Dec 7, 2022

This seems like a reasonable idea to me -- it would be great to eventually migrate away from using protobuf serialization and instead use substrait (as that would allow even better ecosystem integration)

@mingmwang
Copy link
Contributor

👍

@yahoNanJing
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants