Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage input array's null buffer for regex replace to optimize sparse arrays #3803

Closed
isidentical opened this issue Oct 11, 2022 · 0 comments · Fixed by #3804
Closed

Leverage input array's null buffer for regex replace to optimize sparse arrays #3803

isidentical opened this issue Oct 11, 2022 · 0 comments · Fixed by #3804
Labels
enhancement New feature or request

Comments

@isidentical
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We can repurpose the input string array's null buffer directly on the specialized regex implementation so that we won't be spending time on re-building it.

Describe the solution you'd like
When we know only one input is an array (on the specialized case), we should be able to re-use the existing null buffer. The generic case can also be done in a similar fashion but that would be a bit more hard since now we would need to re-combine 4 null buffers (which might be easy with the underlying bitmap representation, though I doubt it would worth the complexity since the specialized path already covers the generic case).

Describe alternatives you've considered
None.

Additional context
Originally from @Dandandan as part of #3518.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant