Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Cargo.lock for datafusion-cli being out-of-date #3744

Closed
isidentical opened this issue Oct 6, 2022 · 0 comments · Fixed by #3745
Closed

Prevent Cargo.lock for datafusion-cli being out-of-date #3744

isidentical opened this issue Oct 6, 2022 · 0 comments · Fixed by #3745
Labels
enhancement New feature or request

Comments

@isidentical
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Since the only Cargo.lock that is checked in is the datafusion-cli's one, we seem to be forgetting about updating it sometimes.

Describe the solution you'd like
Since we already have infrastructure (a lint job), I think it should be relatively simple to add a step that checks whether the Cargo.lock is up-to-date or not. It could then fail on PRs that change Cargo.toml (add new stuff to other crates), and let the PR authors know that they need to update the lock as well.

Describe alternatives you've considered
Leaving as is.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant