You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Since the only Cargo.lock that is checked in is the datafusion-cli's one, we seem to be forgetting about updating it sometimes.
Describe the solution you'd like
Since we already have infrastructure (a lint job), I think it should be relatively simple to add a step that checks whether the Cargo.lock is up-to-date or not. It could then fail on PRs that change Cargo.toml (add new stuff to other crates), and let the PR authors know that they need to update the lock as well.
Describe alternatives you've considered
Leaving as is.
Additional context
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Since the only
Cargo.lock
that is checked in is thedatafusion-cli
's one, we seem to be forgetting about updating it sometimes.Describe the solution you'd like
Since we already have infrastructure (a lint job), I think it should be relatively simple to add a step that checks whether the
Cargo.lock
is up-to-date or not. It could then fail on PRs that changeCargo.toml
(add new stuff to other crates), and let the PR authors know that they need to update the lock as well.Describe alternatives you've considered
Leaving as is.
Additional context
The text was updated successfully, but these errors were encountered: