Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SQL support for tinyint and unsigned versions of all INTs #3307

Closed
Tracked by #3376
kmitchener opened this issue Aug 31, 2022 · 0 comments · Fixed by #3359
Closed
Tracked by #3376

add SQL support for tinyint and unsigned versions of all INTs #3307

kmitchener opened this issue Aug 31, 2022 · 0 comments · Fixed by #3359
Labels
enhancement New feature or request

Comments

@kmitchener
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

Currently there is no SQL support for TINYINT, or the unsigned versions of TINYINT, SMALLINT, INT, and BIGINT.

$ echo "1" > tmp.txt
$ ./target/debug/datafusion-cli.exe
DataFusion CLI v11.0.0
create external table t (c1 tinyint) stored as csv location 'tmp.txt';
NotImplemented("The SQL data type TinyInt(None) is not implemented")
select 1::tinyint;
NotImplemented("Unsupported SQL type TinyInt(None)")
-- or unsigned versions of ints
select 1::int unsigned;
NotImplemented("Unsupported SQL type UnsignedInt(None)")

Describe the solution you'd like
A clear and concise description of what you want to happen.

I'd like SQL support for TINYINT at least. Does DataFusion want SQL support for the unsigned versions of the rest of the INTs? Postgres doesn't support unsigned ints, but sqlparser-rs already has syntax support for it and there are matching Arrow types.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant