Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ballista] Make PhysicalAggregateExprNode has repeated PhysicalExprNode #2180

Closed
Tracked by #2062
Ted-Jiang opened this issue Apr 8, 2022 · 0 comments · Fixed by #2184
Closed
Tracked by #2062

[Ballista] Make PhysicalAggregateExprNode has repeated PhysicalExprNode #2180

Ted-Jiang opened this issue Apr 8, 2022 · 0 comments · Fixed by #2184
Labels
enhancement New feature or request

Comments

@Ted-Jiang
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
in datafusion.proto

message AggregateExprNode {
  AggregateFunction aggr_function = 1;
  repeated LogicalExprNode expr = 2;
}

in ballista.proto

message PhysicalAggregateExprNode {
  datafusion.AggregateFunction aggr_function = 1;
  PhysicalExprNode expr = 2;
}

it will make below query fail in serilize at executor. beacust approx_percentile_cont AggregateExp has two args.

select approx_percentile_cont("o_totalprice", 0.5) from orders;

Describe the solution you'd like
Make

 repeated PhysicalExprNode expr = 2;

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant