Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add alternative_syntax function for docs #13139

Closed
Tracked by #12740
jonathanc-n opened this issue Oct 27, 2024 · 7 comments · Fixed by #13140
Closed
Tracked by #12740

feat: Add alternative_syntax function for docs #13139

jonathanc-n opened this issue Oct 27, 2024 · 7 comments · Fixed by #13140
Assignees
Labels
enhancement New feature or request

Comments

@jonathanc-n
Copy link
Contributor

jonathanc-n commented Oct 27, 2024

Is your feature request related to a problem or challenge?

This is mentioned in #12741 from @Omega359. The doc migration is almost wrapped up, but there are a few functions that are listed in #12741 that have alternative syntax options.

Describe the solution you'd like

Add an alternative_syntax to the docs.

Describe alternatives you've considered

No response

Additional context

No response

@jonathanc-n jonathanc-n added the enhancement New feature or request label Oct 27, 2024
@jonathanc-n
Copy link
Contributor Author

take

@jonathanc-n
Copy link
Contributor Author

jonathanc-n commented Oct 27, 2024

@Omega359 @alamb Hopefully we can get this merged today, I can start working on nthvalue migration to udwf so hopefully we can get the entire doc migration finished by tomorrow. I will be free this week to work on this.

@Omega359
Copy link
Contributor

@jonathanc-n - It's my understanding that typically PR's are left approved but not merged for a day or so to give others an opportunity to comment. We are definitely close to closing out the doc work and I really do appreciate your help in getting this feature across the line! ❤️ I certainly would not have been able to get this far on my own so quickly with my current workload

@jonathanc-n
Copy link
Contributor Author

I'm struggling quite a bit with migrating the ntile, because I need to delete all of the builtinwindow functionality which is causing many bugs in many places that I am not familiar with. Help for #12649 would be appreciated.

@alamb
Copy link
Contributor

alamb commented Oct 28, 2024

@Omega359 @alamb Hopefully we can get this merged today, I can start working on nthvalue migration to udwf so hopefully we can get the entire doc migration finished by tomorrow. I will be free this week to work on this.

Thanks for all your work so far @jonathanc-n

It's my understanding that typically PR's are left approved but not merged for a day or so to give others an opportunity to comment.

Yes exactly. This is explained in a bit more detail in https://datafusion.apache.org/contributor-guide/index.html#pull-request-overview

@Omega359
Copy link
Contributor

I'm struggling quite a bit with migrating the ntile, because I need to delete all of the builtinwindow functionality which is causing many bugs in many places that I am not familiar with. Help for #12649 would be appreciated.

If you can push to a branch in your git repo I may be able to take a look this week.

@jonathanc-n
Copy link
Contributor Author

jonathanc-n commented Oct 29, 2024

@Omega359 Sounds good, thank you! Just to note, it is a little messy right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants