Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RewriteDisjuntivePredicate should only change Exprs that it simplifies #13031

Closed
eejbyfeldt opened this issue Oct 21, 2024 · 0 comments · Fixed by #13032
Closed

RewriteDisjuntivePredicate should only change Exprs that it simplifies #13031

eejbyfeldt opened this issue Oct 21, 2024 · 0 comments · Fixed by #13032
Labels
bug Something isn't working

Comments

@eejbyfeldt
Copy link
Contributor

Describe the bug

Currently RewriteDisjuntivePredicate will always change the structure of Exprs by flatting AND/OR nodes and later recombining them. This caused me problems when looking into resolving #3770 as removing the duplicated SimplifyExpressions optimizer rule lead to test failures due to RewriteDisjuntivePredicate running in between applications.

To Reproduce

No response

Expected behavior

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@eejbyfeldt