Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop copying LogicalPlan and Exprs in RewriteDisjunctivePredicate #10213

Closed
alamb opened this issue Apr 24, 2024 · 2 comments · Fixed by #10305
Closed

Stop copying LogicalPlan and Exprs in RewriteDisjunctivePredicate #10213

alamb opened this issue Apr 24, 2024 · 2 comments · Fixed by #10305
Labels
good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Apr 24, 2024

Is your feature request related to a problem or challenge?

As part of making the planner faster, we are updating the passes to avoid copying LogicalPlan and Expr (see #9637)

Describe the solution you'd like

I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)

Describe alternatives you've considered

Apply the model from @Lordworms in #10166 to RewriteDisjunctivePredicate .

Additional context

I think this will be a pretty simple refactor with a good existing pattern, so mark this as good first issue

@alamb alamb changed the title RewriteDisjunctivePredicate Stop copying LogicalPlan and Exprs in RewriteDisjunctivePredicate Apr 24, 2024
@alamb alamb added the good first issue Good for newcomers label Apr 24, 2024
@rohitrastogi
Copy link
Contributor

I'll take this one.

@alamb
Copy link
Contributor Author

alamb commented Apr 25, 2024

Thanks @rohitrastogi 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants