fix the clippy

Author: liukun4515

datafusion/src/execution/context.rs

@@ -3914,10 +3914,13 @@ mod tests {
         .await?;
 
         // decimal query
-        let result = plan_and_collect(&mut ctx, "select min(c1) from aggregate_simple")
-            .await
-            .unwrap();
-        println!("{:?}", result);
+
+        // let result = plan_and_collect(&mut ctx, "select min(c1) from aggregate_simple")
+        //     .await
+        //     .unwrap();
+        //
+        // println!("{:?}", result);
+
         Ok(())
     }
 

datafusion/src/physical_plan/expressions/average.rs

@@ -63,16 +63,23 @@ pub fn avg_return_type(arg_type: &DataType) -> Result<DataType> {
 }
 
 pub(crate) fn is_avg_support_arg_type(arg_type: &DataType) -> bool {
-    match arg_type {
-        // TODO: do we need to support the unsigned data type?
-        DataType::UInt8 | DataType::UInt16 | DataType::UInt32 | DataType::UInt64 => true,
-        DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => true,
-        DataType::Float16 | DataType::Float32 | DataType::Float64 => true,
-        // TODO support the decimal data type
-        DataType::Decimal(_, _) => true,
-        // TODO support the interva
-        _ => false,
-    }
+    // TODO support the interval
+    // TODO: do we need to support the unsigned data type?
+    matches!(
+        arg_type,
+        DataType::UInt8
+            | DataType::UInt16
+            | DataType::UInt32
+            | DataType::UInt64
+            | DataType::Int8
+            | DataType::Int16
+            | DataType::Int32
+            | DataType::Int64
+            | DataType::Float16
+            | DataType::Float32
+            | DataType::Float64
+            | DataType::Decimal(_, _)
+    )
 }
 
 impl Avg {

datafusion/src/physical_plan/expressions/sum.rs

@@ -64,16 +64,23 @@ pub fn sum_return_type(arg_type: &DataType) -> Result<DataType> {
 }
 
 pub(crate) fn is_sum_support_arg_type(arg_type: &DataType) -> bool {
-    match arg_type {
-        // TODO: do we need to support the unsigned data type?
-        DataType::UInt8 | DataType::UInt16 | DataType::UInt32 | DataType::UInt64 => true,
-        DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => true,
-        DataType::Float16 | DataType::Float32 | DataType::Float64 => true,
-        // TODO support the decimal data type
-        DataType::Decimal(_, _) => true,
-        // TODO support the interva
-        _ => false,
-    }
+    // TODO support the interval
+    // TODO: do we need to support the unsigned data type?
+    matches!(
+        arg_type,
+        DataType::UInt8
+            | DataType::UInt16
+            | DataType::UInt32
+            | DataType::UInt64
+            | DataType::Int8
+            | DataType::Int16
+            | DataType::Int32
+            | DataType::Int64
+            | DataType::Float16
+            | DataType::Float32
+            | DataType::Float64
+            | DataType::Decimal(_, _)
+    )
 }
 
 impl Sum {

datafusion/src/physical_plan/type_coercion.rs

@@ -145,8 +145,6 @@ fn maybe_data_types(
     valid_types: &[DataType],
     current_types: &[DataType],
 ) -> Option<Vec<DataType>> {
-    // TODO liukun4515
-
     if valid_types.len() != current_types.len() {
         return None;
     }
@@ -157,13 +155,10 @@ fn maybe_data_types(
 
         if current_type == valid_type {
             new_type.push(current_type.clone())
+        } else if can_coerce_from(valid_type, current_type) {
+            new_type.push(valid_type.clone())
         } else {
-            if can_coerce_from(valid_type, current_type) {
-                new_type.push(valid_type.clone())
-            } else {
-                // not possible
-                return None;
-            }
+            return None;
         }
     }
     Some(new_type)
@@ -175,7 +170,6 @@ fn maybe_data_types(
 /// See the module level documentation for more detail on coercion.
 fn can_coerce_from(type_into: &DataType, type_from: &DataType) -> bool {
     use self::DataType::*;
-    // TODO liukun4515
     match type_into {
         // TODO, decimal data type, we just support the decimal
         Int8 => matches!(type_from, Int8),