Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CometSparkToColumnar should have different name for row vs columnar input #936

Open
andygrove opened this issue Sep 11, 2024 · 3 comments · May be fixed by #958
Open

CometSparkToColumnar should have different name for row vs columnar input #936

andygrove opened this issue Sep 11, 2024 · 3 comments · May be fixed by #958
Assignees
@JensonChoi
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andygrove
Copy link
Member

andygrove commented Sep 11, 2024 •
edited
Loading

What is the problem the feature request solves?

I would like to change the nodeName for CometSparkToColumnar as follows:

 override def nodeName: String = if (child.supportsColumnar) {
    "CometSparkColumnarToColumnar"
  } else {
    "CometSparkRowToColumnar"
  }

This makes it easier to comprehend which version is being used in a plan:

+- == Final Plan ==
   *(1) ColumnarToRow
   +- !CometHashAggregate [key#6L, count#88L], Final, [key#6L], [count(1)]
      +- !CometHashAggregate [key#6L], Partial, [key#6L], [partial_count(1)]
         +- CometSparkColumnarToColumnar
            +- Scan In-memory table abc [key#6L]
                  +- InMemoryRelation [key#6L, value#7L, (key + 1)#10L], StorageLevel(disk, memory, deserialized, 1 replicas)
                        +- *(2) ColumnarToRow
                           +- CometProject [key#6L, value#7L, (key + 1)#10L], [id#0L AS key#6L, (id#0L % 8) AS value#7L, (id#0L + 1) AS (key + 1)#10L]
                              +- CometSparkRowToColumnar
                                 +- *(1) Range (0, 1000, step=1, splits=5)

Describe the potential solution

No response

Additional context

No response
@andygrove andygrove added enhancement New feature or request good first issue Good for newcomers labels Sep 11, 2024
@parthchandra
Copy link
Contributor

Maybe just override the simpleString and verboseString methods?

@JensonChoi
Copy link

Hey, I'd love to pick this up if possible. Thanks.

@viirya
Copy link
Member

viirya commented Sep 21, 2024

@JensonChoi Thanks. I assigned this to you. Please feel free to open PR.

@JensonChoi JensonChoi linked a pull request Sep 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JensonChoi JensonChoi

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Override node name for CometSparkToColumnar JensonChoi/datafusion-comet
4 participants
@viirya @andygrove @parthchandra @JensonChoi