Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CometShuffleExchangeExec logical link is different to Spark ShuffleExchangeExec #323

Closed
viirya opened this issue Apr 25, 2024 · 0 comments · Fixed by #324
Closed

CometShuffleExchangeExec logical link is different to Spark ShuffleExchangeExec #323

viirya opened this issue Apr 25, 2024 · 0 comments · Fixed by #324
Labels
bug Something isn't working

Comments

@viirya
Copy link
Member

viirya commented Apr 25, 2024 •
edited
Loading

Describe the bug

Enabling columnar shuffle by default PR #250 causes a lot of test failures in Spark org.apache.spark.sql.execution.adaptive.AdaptiveQueryExecSuite.

This is a tricky bug.

I found that it is because Comet sets incorrect logical link to CometShuffleExchangeExec. Because logical link is used in Spark AQE framework to do query planning, incorrect logical links cause test failures there.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: CometShuffleExchangeExec logical link should be correct viirya/arrow-datafusion-comet
1 participant
@viirya