Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of update metrics #1328

Open
wForget opened this issue Jan 23, 2025 · 1 comment · May be fixed by #1329
Open

Improve performance of update metrics #1328

wForget opened this issue Jan 23, 2025 · 1 comment · May be fixed by #1329
Labels
enhancement New feature or request

Comments

@wForget
Copy link
Member

wForget commented Jan 23, 2025 •
edited
Loading

What is the problem the feature request solves?

When I profiled tpcds q64, I found that update_metrics took 8.9 % of task time.

Image

Describe the potential solution

I propose the following improvements to optimize update metrics:

  • Define a NativeMetricNode proto type to pass all metric nodes at once to avoid iterative jni calls.
  • Call update metrics when releasing plan to reduce the number of calls.

Additional context

No response
@wForget wForget added the enhancement New feature or request label Jan 23, 2025
@wForget wForget linked a pull request Jan 23, 2025 that will close this issue
Draft
@wForget
Copy link
Member Author

wForget commented Jan 23, 2025

Similar to #391 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: improve performance of update metrics wForget/arrow-datafusion-comet
1 participant
@wForget