Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more types to BloomFilterAgg #1023

Closed
mbutrovich opened this issue Oct 18, 2024 · 0 comments · Fixed by #1039
Closed

Add more types to BloomFilterAgg #1023

mbutrovich opened this issue Oct 18, 2024 · 0 comments · Fixed by #1039
Assignees
Labels
enhancement New feature or request

Comments

@mbutrovich
Copy link
Contributor

What is the problem the feature request solves?

#987 introduces native BloomFilterAgg with support for LongType, as in Spark 3.4. Spark 3.5+ added support for other integer types, and strings.

Describe the potential solution

For the other integer types, this should be easy to handle with a cast and use the existing put_long bloom filter method to match Spark behavior. For strings, the underlying bloom filter implementation needs a put_bytes method to match Spark's bloom filter behavior.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant