Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should run Ballista integration tests #24

Open
andygrove opened this issue May 11, 2021 · 4 comments
Open

CI should run Ballista integration tests #24

andygrove opened this issue May 11, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We are seeing PRs merged that cause regressions in Ballista because we currently rely on manual integration testing.

Describe the solution you'd like
CI should run the integration tests:

./dev/integration-tests.sh

Describe alternatives you've considered
None

Additional context
None

@alamb
Copy link
Contributor

alamb commented Mar 24, 2022

The lack of ballista coverage in CI came up again with @gaojun2048 @liukun4515 and @mingmwang
on apache/datafusion#2070 (comment)

@liukun4515
Copy link
Contributor

I can take this task in the Q2

@houqp
Copy link
Member

houqp commented Mar 28, 2022

Thank you @liukun4515 ! In case you missed it, the setup I had in apache/datafusion#688 already works and was only paused pending optimizations to reduce cache size. I imagine you might be able to reuse some of the setup there when you start working on this this task.

@andygrove
Copy link
Member Author

Should we consider running the integration tests in CI without creating docker images? Just run the native binaries for scheduler and executor?

@andygrove andygrove transferred this issue from apache/datafusion May 19, 2022
yahoNanJing referenced this issue in yahoNanJing/arrow-ballista Dec 13, 2022
* Fix dead lock issue when using dashmap

* Minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants