Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal pbxProject.prototype.addTargetDependency call not properly tested #73

Closed
brody4hire opened this issue Oct 20, 2019 · 0 comments · Fixed by #76
Closed

Internal pbxProject.prototype.addTargetDependency call not properly tested #73

brody4hire opened this issue Oct 20, 2019 · 0 comments · Fixed by #76

Comments

@brody4hire
Copy link

From Stryker mutation testing (see PR #61) of WatchKit 2 support (PR #56), I discovered that the following change does not trigger a test failure:

diff --git a/lib/pbxProject.js b/lib/pbxProject.js
index be9f473..5a7702a 100644
--- a/lib/pbxProject.js
+++ b/lib/pbxProject.js
@@ -1483,7 +1483,7 @@ pbxProject.prototype.addTarget = function(name, type, subfolder) {
     this.addToPbxProjectSection(target);
 
     // Target: Add dependency for this target to first (main) target
-    this.addTargetDependency(this.getFirstTarget().uuid, [target.uuid]);
+    this.addTargetDependency(this.getFirstTarget().uuid, []);
 
 
     // Return target on success

I think test coverage of this possible mutation needs to be added before we merge PR #56, which moves this piece of code into the else clause of an if statement.

/cc @l3ender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant