Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing page is obsolete #5386

Closed
squakez opened this issue Apr 18, 2024 · 5 comments · Fixed by #5393
Closed

Contributing page is obsolete #5386

squakez opened this issue Apr 18, 2024 · 5 comments · Fixed by #5393
Assignees
Labels
area/documentation Documentation task good first issue Does not require full understanding of the codebase

Comments

@squakez
Copy link
Contributor

squakez commented Apr 18, 2024

See https://camel.apache.org/camel-k/2.3.x/contributing/developers.html

We should provide up to date information.

@squakez squakez added good first issue Does not require full understanding of the codebase area/documentation Documentation task labels Apr 18, 2024
@vkrejcirik
Copy link
Contributor

I will look into this one as my first contribution to the project. Can you assigned this issue to me?

@squakez
Copy link
Contributor Author

squakez commented Apr 19, 2024

Great, thanks! Feel free to contact for any required support.

@vkrejcirik
Copy link
Contributor

vkrejcirik commented Apr 19, 2024

@squakez I followed instruction in Contributing to Camel K and I faced an issue when running make lint. The Makefile is using golangci-lint with parameter --deadline, but it seems like this is not valid parameter anymore. At least in the most recent version - 1.57.2. Do you like to create new issue for it?

@squakez
Copy link
Contributor Author

squakez commented Apr 19, 2024

Yes, I think we're actually using 1.55.2 version. Probably it is worth to mention this in the instructions to verify which is the actual version we are using. Also mind that the part mentioning pre-commit install is something that may not work either and it could be removed from the guide.

@vkrejcirik
Copy link
Contributor

I downgraded to version v1.55.2 and it worked just fine. I added specific version into instruction. I removed pre-commit option from the page. I'm not able to verify the Windows specific instructions since I'm running on MacOS. So, hopefully that's okay. I was able to build the complete project just fine as well as Camel K operator image.

@squakez squakez linked a pull request Apr 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation task good first issue Does not require full understanding of the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants