From 0b90cfc2e70f22cc681df829d994b967a47d3a5d Mon Sep 17 00:00:00 2001 From: Qiang Huang Date: Sat, 3 Dec 2022 21:32:21 +0800 Subject: [PATCH] refactor ByteBuf release usage --- .../allocator/impl/ByteBufAllocatorBuilderTest.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/bookkeeper-common-allocator/src/test/java/org/apache/bookkeeper/common/allocator/impl/ByteBufAllocatorBuilderTest.java b/bookkeeper-common-allocator/src/test/java/org/apache/bookkeeper/common/allocator/impl/ByteBufAllocatorBuilderTest.java index cda0416c5fb..89a9f6ce2c5 100644 --- a/bookkeeper-common-allocator/src/test/java/org/apache/bookkeeper/common/allocator/impl/ByteBufAllocatorBuilderTest.java +++ b/bookkeeper-common-allocator/src/test/java/org/apache/bookkeeper/common/allocator/impl/ByteBufAllocatorBuilderTest.java @@ -29,6 +29,7 @@ import io.netty.buffer.ByteBufAllocator; import io.netty.buffer.PooledByteBufAllocator; import io.netty.buffer.UnpooledByteBufAllocator; +import io.netty.util.ReferenceCountUtil; import java.lang.reflect.Constructor; import java.util.concurrent.atomic.AtomicReference; import org.apache.bookkeeper.common.allocator.ByteBufAllocatorBuilder; @@ -229,17 +230,17 @@ public void testPooled() { ByteBuf buf1 = alloc.buffer(); assertEquals(pooledAlloc, buf1.alloc()); assertFalse(buf1.hasArray()); - buf1.release(); + ReferenceCountUtil.safeRelease(buf1); ByteBuf buf2 = alloc.directBuffer(); assertEquals(pooledAlloc, buf2.alloc()); assertFalse(buf2.hasArray()); - buf2.release(); + ReferenceCountUtil.safeRelease(buf2); ByteBuf buf3 = alloc.heapBuffer(); assertEquals(pooledAlloc, buf3.alloc()); assertTrue(buf3.hasArray()); - buf3.release(); + ReferenceCountUtil.safeRelease(buf3); } @Test @@ -255,14 +256,14 @@ public void testPooledWithDefaultAllocator() { assertEquals(PooledByteBufAllocator.class, buf1.alloc().getClass()); assertEquals(3, ((PooledByteBufAllocator) buf1.alloc()).metric().numDirectArenas()); assertFalse(buf1.hasArray()); - buf1.release(); + ReferenceCountUtil.safeRelease(buf1); ByteBuf buf2 = alloc.directBuffer(); assertFalse(buf2.hasArray()); - buf2.release(); + ReferenceCountUtil.safeRelease(buf2); ByteBuf buf3 = alloc.heapBuffer(); assertTrue(buf3.hasArray()); - buf3.release(); + ReferenceCountUtil.safeRelease(buf3); } }