Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Remove need for tf.function in TF ModelHandler #23584

Closed
damccorm opened this issue Oct 11, 2022 · 1 comment
Closed

[Feature Request]: Remove need for tf.function in TF ModelHandler #23584

damccorm opened this issue Oct 11, 2022 · 1 comment
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. ml new feature P2 python run-inference

Comments

@damccorm
Copy link
Contributor

What would you like to happen?

Right now, to use the Tensorflow model handler you need to take in a string tf.example. To support models that don't do this and take in something like a numpy array of floats, we currently recommend adding a tf.function (see https://github.com/apache/beam/blob/c36077a96a4691ca9000c8b243847ac6c7f82a74/examples/notebooks/beam-ml/run_inference_tensorflow.ipynb). We should automatically support this use case, and ideally do so more generally.

Issue Priority

Priority: 2

Issue Component

Component: run-inference

@damccorm
Copy link
Contributor Author

Completed by #25366

@damccorm damccorm added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Apr 17, 2023
@github-actions github-actions bot added this to the 2.48.0 Release milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. ml new feature P2 python run-inference
Projects
None yet
Development

No branches or pull requests

1 participant