-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RowSelection::iter()
, Into<Vec<RowSelector>>
and example
#3173
Conversation
RowSelection::iter()
, Into<Vec<RowSelector>>
and example
pub fn iter(&self) -> impl Iterator<Item = &RowSelector> { | ||
self.selectors.iter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub fn iter(&self) -> impl Iterator<Item = &RowSelector> { | |
self.selectors.iter() | |
pub fn iter(&self) -> impl Iterator<Item = RowSelector> { | |
self.selectors.iter().copied() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to copy the RowSelectors around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not especially, was just an idle suggestion
Benchmark runs are scheduled for baseline = f749e1d and contender = cea5146. cea5146 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3172
Rationale for this change
see #3172 (Datafusion code wants to count the number of selected items)
What changes are included in this PR?
RowSelection::iter()
Into<Vec<RowSelector>>
(there was only into VecDeque for some reason)Are there any user-facing changes?
new functions and docs