Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder support for Int8 keys #6844

Closed
ajwerner opened this issue Dec 6, 2024 · 1 comment · Fixed by #6845
Closed

Add builder support for Int8 keys #6844

ajwerner opened this issue Dec 6, 2024 · 1 comment · Fixed by #6845
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Dec 6, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I would like to be able to create a DictionaryBuilder with an int8 key type. #6589 added support for some dictionaries to the builder, but it didn't support all the key types. There was some concern about code bloat, and that is warranted, but it's also the case that dictionaries with small numbers of values (sometimes just 1) come up.

Describe the solution you'd like
Also support int8 keys.

Describe alternatives you've considered
Fork the entire builder infrastructure?

@ajwerner ajwerner added the enhancement Any new improvement worthy of a entry in the changelog label Dec 6, 2024
@alamb alamb added the arrow Changes to the arrow crate label Dec 17, 2024
@alamb
Copy link
Contributor

alamb commented Dec 17, 2024

label_issue.py automatically added labels {'arrow'} from #6845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants