Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Flight / FlightSQL Integration Tests #6546

Open
tustvold opened this issue Oct 11, 2024 · 4 comments
Open

Enable Flight / FlightSQL Integration Tests #6546

tustvold opened this issue Oct 11, 2024 · 4 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Archery provides Flight and FlightSQL Integration tests, we should enable these and fix any issues they turn up -
https://github.com/apache/arrow/blob/45b36976a31a4f363c0c471c2da1abd5bee97fd2/dev%2Farchery%2Farchery%2Fintegration%2Frunner.py#L689-L703

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted labels Oct 11, 2024
@tustvold
Copy link
Contributor Author

@alamb perhaps someone from Influx might be able to help out on this one?

@alamb
Copy link
Contributor

alamb commented Oct 15, 2024

Thanks @tustvold -- I will put it on our backlog

We have seen / hit some issues with customers using golang clients in the past so this would be a useful thing to work on

@davisp
Copy link
Member

davisp commented Dec 9, 2024

So I've spent most of today trying to get the archery integration flight_sql test running against a Rust FlightSQL server. I've managed to get C++ and Go running against the Rust version (though it blows up because I've left all methods unimplemented) but it at least shows its not super crazy to get things started. Going with Docker once the Rust version has been implemented will likely be a good idea.

However, I can't for the life of me find some description of what these tests are actually expected to be doing. The Go and C++ runners manage to blow up because the test server is completely unimplemented. Skimming through the versions of the test server in Go and C++, I'm just seeing lots of hard coded values and expectations which I'm not gonna spend my time on reverse engineering.

If anyone is interested in the Rust work, I've pushed it all to a branch here: main...davisp:arrow-rs:run-apache-archery-integration-flight-sql

@alamb
Copy link
Contributor

alamb commented Dec 9, 2024

I looked at the documentation on https://arrow.apache.org/docs/format/Integration.html and I agree I could not find anything related to FlightSQL

github archeology lead me to apache/arrow@968e6ea which introduced the tests, but I didn't find any human readable documentation other than code

Thank you for working on this @davisp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

No branches or pull requests

3 participants