Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(license): update LICENSE.txt #290

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

zeroshade
Copy link
Member

Rationale for this change

Fixes #275

What changes are included in this PR?

Removing "safe-math" from being vendored as it's no longer being used. Updating the LICENSE.txt with all appropriate information including files which contain code that has been copied from other projects.

@zeroshade
Copy link
Member Author

CC @jbonofre @jas4711

Please take a look and confirm if I missed anything, thanks!

@jas4711
Copy link
Contributor

jas4711 commented Feb 18, 2025

Thank you! Looks good to me, even though it does not add any copyright notices for ASF. I was expecting something like:

Copyright (C) Apache Software Foundation

Is there any reason you do not want this to be in the git repo? I don't care strongly about legal reasons here, but there is a lot of license scanners that search for 'Copyright' as a string to find licenses and authors. It would have saved me some uncertainty when trying to figure out Debian's debian/copyright file for this package if there were more clear copyright notices pointing at the ASF. Sometimes the exact legal name is significant too.

@zeroshade
Copy link
Member Author

zeroshade commented Feb 18, 2025

The NOTICE.txt file contains the line Copyright 2016-2025 The Apache Software Foundation and the heading of every source file has the standard Apache License which includes See the NOTICE file distributed with this work for additional information regarding copyright ownership.

In addition every source file heading starts with Licensed to the Apache Software Foundation (ASF) 😄

Is that sufficient?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

In general, ASF projects write "Copyright YYYY The Apache Software Foundation" in NOTICE not LICENSE.

See also: https://infra.apache.org/licensing-howto.html#step-by-step

@jbonofre
Copy link
Member

Thanks ! As you removed safe-math, the LICENSE doesn't have to be updated.

About the code copied from LLVM, it's OK in the LICENSE and no need to update NOTICE as LLVM doesn't provide a NOTICE.

The dependency copyright doesn't have to be in NOTICE (NOTICE is to host relevant information from dependency NOTICE).
The copyright should be in LICENSE with the code copied (similar to https://github.com/apache/arrow-java/blob/main/LICENSE.txt#L211).

On the other hand, the project copyright should be in the NOTICE, and we are good here:

Apache Arrow Go
Copyright 2016-2025 The Apache Software Foundation

This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).

So, @zeroshade you are good here ! Thanks !

@zeroshade zeroshade merged commit 6e2e50b into apache:main Feb 19, 2025
23 checks passed
@zeroshade zeroshade deleted the address-license-issues branch February 19, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please clarify copyright holder
5 participants