Support DataFrame.collect for Ballista DataFrames #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Lamb <[email protected]>
andygrove
changed the title
|
I will plan to review this tomorrow |
houqp
approved these changes
Jul 28, 2021
alamb
approved these changes
Jul 28, 2021
| let batch = batch?; | ||
| results.push(batch); | ||
| } | ||
| let results = df.collect().await?; |
| } | ||
|
|
||
| #[async_trait] | ||
| impl ExecutionPlan for DistributedQueryExec { |
Thanks. It was nice that I didn't have to make any changes to DataFusion to make this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #787.
Rationale for this change
A DataFrame from a BallistaContext should work just like a DataFrame from a DataFusion ExecutionContext. The user should be able to directly call execution methods such as
collect.What changes are included in this PR?
DataFrames created by Ballista have a custom query planner that can create Ballista physical plans.
Are there any user-facing changes?
Yes - the user no longer needs to call
BallistaContext::collect.