Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrait] ReadRel. Get column names from TableScan source #5050

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Part of #4897

Original PR in datafusion-substrait repo: datafusion-contrib/datafusion-substrait#37

Rationale for this change

Quick fix to list ALL columns from source table in ReadRel base_schema.

According to Substrait documentation, the base_schema (Direct Schema) property should contain all columns BEFORE projection or emit/hiding is applied.

What changes are included in this PR?

Are these changes tested?

No .. this is applying a PR that was already merged in the original repo prior to us accepting the code donation here, so I am just trying to get those changes re-applied

Are there any user-facing changes?

@andygrove
Copy link
Member Author

@nseekhao fyi

@andygrove andygrove changed the title ReadRel. Get column names from TableScan source [Substrait] ReadRel. Get column names from TableScan source Jan 24, 2023
@andygrove andygrove mentioned this pull request Jan 24, 2023
5 tasks
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@alamb alamb merged commit e30711d into apache:master Jan 24, 2023
@ursabot
Copy link

ursabot commented Jan 24, 2023

Benchmark runs are scheduled for baseline = 3f5b834 and contender = e30711d. e30711d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove deleted the read-rel-fix branch January 27, 2023 18:55
martin-g added a commit to martin-g/arrow-datafusion that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants