[Enhancement] early check table exist before create #4998
Conversation
There was a problem hiding this comment.
Thank you for the contribution @xiaoyong-z
I think a test is needed for this behavior so we don't accidentally break it in the future (unless it is covered by existing tests). I'll kick of CI and we'll find out
Currently, when creating an external table, we won't check whether it exist or not, always create a new table. To create a new table, we need to read data from csv/json/parquet and infer the type, this will bring a lot of overhead. In this pr, before creating an external table, we can check whether table exist or not, if it exist, directly return. Signed-off-by: xyz <[email protected]>
xiaoyong-z
force-pushed
the
early-check-table-exist-before-create
branch
from
ae26ac3 to
054f014
Compare
|
Benchmark runs are scheduled for baseline = 8dc4c96 and contender = 64714ee. 64714ee is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Currently, when creating an external table, we won't check whether it exist or not, always create a new table. To create a new table, we need to read data from csv/json/parquet and infer the type, this will bring a lot of extra overhead.
In this pr, before creating an external table, we can check whether table exist or not, if it exist, directly return.
Signed-off-by: xyz [email protected]
Which issue does this PR close?
Closes #4997
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?