-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: Update data type support documentation #4984
Conversation
| `DATE` | `Date32` | | ||
| `TIME` | `Time64(TimeUnit::Nanosecond)` | | ||
| `TIMESTAMP` | `Timestamp(TimeUnit::Nanosecond, None)` | | ||
| `INTERVAL` | `Interval(IntervalUnit::YearMonth)` or `Interval(IntervalUnit::DayTime)` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intervals work great:
❯ select now() + interval '1 minute';
+----------------------------------+
| now() + IntervalDayTime("60000") |
+----------------------------------+
| 2023-01-19T14:30:03.656542+00:00 |
+----------------------------------+
❯ select arrow_typeof(interval '1 month');
+-------------------------------------+
| arrowtypeof(IntervalYearMonth("1")) |
+-------------------------------------+
| Interval(YearMonth) |
+-------------------------------------+
1 row in set. Query took 0.006 seconds.
❯ select arrow_typeof(interval '1 second');
+--------------------------------------+
| arrowtypeof(IntervalDayTime("1000")) |
+--------------------------------------+
| Interval(DayTime) |
+--------------------------------------+
## Character Types | ||
|
||
| SQL DataType | Arrow DataType | | ||
| ------------ | -------------- | | ||
| `CHAR` | `Utf8` | | ||
| `VARCHAR` | `Utf8` | | ||
| `TEXT` | `Utf8` | | ||
| `STRING` | `Utf8` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❯ create table foo (x string) as select 'foo';
0 rows in set. Query took 0.003 seconds.
@@ -42,8 +42,7 @@ jobs: | |||
node-version: "14" | |||
- name: Prettier check | |||
run: | | |||
# if you encounter error, try rerun the command below with --write instead of --check | |||
# and commit the changes | |||
# if you encounter error, rerun the command below and commit the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
driveby cleanup (the command below actually uses --write
rather than --check
already
Benchmark runs are scheduled for baseline = 5dd5ffd and contender = 03601be. 03601be is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
N/A
Rationale for this change
https://arrow.apache.org/datafusion/user-guide/sql/data_types.html is out of date, as we discovered while working on docs for IOx: influxdata/docs-v2#4700
What changes are included in this PR?
arrow_typeof
functionAre these changes tested?
N/A (they are docs)
Are there any user-facing changes?
Yes, docs