-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datafusion-substrait crate to workspace #4893
Conversation
Windows build fails with:
|
I filed substrait-io/substrait-rs#53 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark runs are scheduled for baseline = 933e5ba and contender = 2f0ed38. 2f0ed38 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4880
Rationale for this change
We want
cargo build
to build all crates.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?