Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve Column::normalize_with_schemas docs #4871

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

crepererum
Copy link
Contributor

Which issue does this PR close?

None.

Rationale for this change

While debugging #4854 I got a bit confused because the docs of normalize_col_with_schemas and normalize_col just state "uses Column::normalize_with_schemas but the latter just says "internal implementation" and I had to read throw the code to understand what "normalize" actually means.

What changes are included in this PR?

Docs for Column::normalize_with_schemas.

Are these changes tested?

-

Are there any user-facing changes?

Better docs.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 315f5b9 into apache:master Jan 11, 2023
@alamb
Copy link
Contributor

alamb commented Jan 11, 2023

Thank you @crepererum

@ursabot
Copy link

ursabot commented Jan 11, 2023

Benchmark runs are scheduled for baseline = 39d98f8 and contender = 315f5b9. 315f5b9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants