Support using var/var_pop/stddev/stddev_pop in window expressions with custom frames #4848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #4846 for
var
,var_pop
,stddev
, andstddev_pop
.The actual
retract_batch
function was already implemented, but it looks like thecreate_sliding_accumulator
implementations weren't added previously so it wasn't possible to use these aggregate functions in window expressions that use custom frames.Are these changes tested?
The test added in effc472 will fail until #4847 is merged and this branch is updated.
I'll mark this is draft until then.
Are there any user-facing changes?
var
,var_pop
,stddev
, andstddev_pop
will now work in window expressions that use custom frames rather than raising an error.