Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using var/var_pop/stddev/stddev_pop in window expressions with custom frames #4848

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

jonmmease
Copy link
Contributor

@jonmmease jonmmease commented Jan 8, 2023

Which issue does this PR close?

Follow on to #4846 for var, var_pop, stddev, and stddev_pop.

The actual retract_batch function was already implemented, but it looks like the create_sliding_accumulator implementations weren't added previously so it wasn't possible to use these aggregate functions in window expressions that use custom frames.

Are these changes tested?

The test added in effc472 will fail until #4847 is merged and this branch is updated.

I'll mark this is draft until then.

Are there any user-facing changes?

var, var_pop, stddev, and stddev_pop will now work in window expressions that use custom frames rather than raising an error.

@jonmmease jonmmease marked this pull request as draft January 8, 2023 01:35
@github-actions github-actions bot added core Core DataFusion crate physical-expr Physical Expressions labels Jan 8, 2023
@jonmmease jonmmease marked this pull request as ready for review January 8, 2023 13:57
@jonmmease
Copy link
Contributor Author

Ok, this is ready to go now. Thanks!

Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jonmmease
Copy link
Contributor Author

Can this be merged? Thanks!

@alamb
Copy link
Contributor

alamb commented Jan 10, 2023

Nice -- thank you @jonmmease and @ozankabak

@alamb alamb merged commit 292eb95 into apache:master Jan 10, 2023
@ursabot
Copy link

ursabot commented Jan 10, 2023

Benchmark runs are scheduled for baseline = 13fb42e and contender = 292eb95. 292eb95 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants