-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tpch sqllogicaltest and remove some duplicated test #4802
Conversation
Some query result is strange, but run successfully.🤔 |
These tests are really to check that subqueries get rewritten as joins rather than being about tpch. The change in the test here just checks for correct results and does not check the details of how the plans are rewritten, so I feel like we are losing some value with this change. However, we also check for expected plans in tpch so maybe this is fine. Would be good to check with @avantgardnerio who originally implemented these tests, or @iajoiner. |
After a careful comparison, I find that they are not exactly the same. But they have the same effect, and I'm not sure whether to remove them. Looking forward to listening the opinion of @avantgardnerio and @iajoiner . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jackwener
Unless I hear otherwise from anyone I plan to merge this PR in the next day or two
I think it is a significant testing improvement -- given we now have the proper tpch test in https://github.com/apache/arrow-datafusion/blob/169b5228800f991be913b10ffdfd161e2cbc7baf/.github/workflows/rust.yml#L126-L165 I am not even sure the new slt test is adding much value 🤔
Benchmark runs are scheduled for baseline = 63ae2b9 and contender = e393b28. e393b28 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4801.
Rationale for this change
I just want to remove tpch in Unit-Test, because it's duplicated with independent test for TPCH.
But these UT contains some data-test, so I add sqllogicaltest for it.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?