Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tpch sqllogicaltest and remove some duplicated test #4802

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Jan 3, 2023

Which issue does this PR close?

Closes #4801.

Rationale for this change

I just want to remove tpch in Unit-Test, because it's duplicated with independent test for TPCH.
But these UT contains some data-test, so I add sqllogicaltest for it.

What changes are included in this PR?

  • add tpch sqllogicaltest
  • remove some duplicated test.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jan 3, 2023
@jackwener
Copy link
Member Author

Some query result is strange, but run successfully.🤔

@andygrove
Copy link
Member

These tests are really to check that subqueries get rewritten as joins rather than being about tpch. The change in the test here just checks for correct results and does not check the details of how the plans are rewritten, so I feel like we are losing some value with this change. However, we also check for expected plans in tpch so maybe this is fine. Would be good to check with @avantgardnerio who originally implemented these tests, or @iajoiner.

@jackwener
Copy link
Member Author

jackwener commented Jan 3, 2023

These tests are really to check that subqueries get rewritten as joins rather than being about tpch. The change in the test here just checks for correct results and does not check the details of how the plans are rewritten, so I feel like we are losing some value with this change. However, we also check for expected plans in tpch so maybe this is fine. Would be good to check with @avantgardnerio who originally implemented these tests, or @iajoiner.

After a careful comparison, I find that they are not exactly the same. But they have the same effect, and I'm not sure whether to remove them. Looking forward to listening the opinion of @avantgardnerio and @iajoiner .

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jackwener

Unless I hear otherwise from anyone I plan to merge this PR in the next day or two

I think it is a significant testing improvement -- given we now have the proper tpch test in https://github.com/apache/arrow-datafusion/blob/169b5228800f991be913b10ffdfd161e2cbc7baf/.github/workflows/rust.yml#L126-L165 I am not even sure the new slt test is adding much value 🤔

@alamb alamb merged commit e393b28 into apache:master Jan 8, 2023
@ursabot
Copy link

ursabot commented Jan 8, 2023

Benchmark runs are scheduled for baseline = 63ae2b9 and contender = e393b28. e393b28 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add sqllogicaltest for tpch and remove some duplicated test.
4 participants