Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: comments about coercion in physical planner #4745

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Minor: comments about coercion in physical planner #4745

merged 1 commit into from
Dec 28, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 27, 2022 •
edited
Loading

Which issue does this PR close?

As pointed out by @liukun4515 on #4726 #4726 (comment) type coercion is not needed during physical planning

cc @comphead

Rationale for this change

Code is uneeded

Avoid confusion about design in the future

What changes are included in this PR?

Remove uneeded code

Add comments about coercion in the physical planner

Are these changes tested?

Yes, all existing tests pass

Are there any user-facing changes?

No

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Dec 27, 2022
@alamb alamb mentioned this pull request Dec 27, 2022
Merged
@alamb alamb marked this pull request as ready for review December 27, 2022 14:40
@alamb alamb marked this pull request as draft December 27, 2022 14:47
@alamb
Copy link
Contributor Author

alamb commented Dec 27, 2022

@liukun4515 already made
#4741 which contains most of this PR.

This one has some improved comments, so I'll plan to polish it up once
#4741 is merged

liukun4515
liukun4515 reviewed Dec 28, 2022
View reviewed changes
datafusion/physical-expr/src/planner.rs
expressions::cast(rhs, input_schema, target_datatype)?,
input_schema,
)
// Note that the logical planner is responsible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

liukun4515
liukun4515 approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for your comments

@alamb alamb force-pushed the alamb/remove_unecessary_coercion branch from fe730c1 to 23b140b Compare December 28, 2022 12:25
@github-actions github-actions bot removed the logical-expr Logical plan and expressions label Dec 28, 2022
@alamb alamb changed the title Minor: Remove unecessary physical coercion Minor: comments about coercion in physical planner Dec 28, 2022
@alamb alamb marked this pull request as ready for review December 28, 2022 12:26
@alamb
Copy link
Contributor Author

alamb commented Dec 28, 2022

I plan to merge this PR once CI has passed

@alamb alamb merged commit 3abbffb into apache:master Dec 28, 2022
@alamb alamb deleted the alamb/remove_unecessary_coercion branch December 28, 2022 21:03
@ursabot
Copy link

ursabot commented Dec 28, 2022

Benchmark runs are scheduled for baseline = fc8fb06 and contender = 3abbffb. 3abbffb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liukun4515 liukun4515 liukun4515 approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @liukun4515