Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cargo clippy warning #4652

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix cargo clippy warning #4652

merged 1 commit into from
Dec 16, 2022

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Dec 16, 2022 •
edited
Loading

Which issue does this PR close?

Closes #4653 #4654 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Dec 16, 2022
@HaoYang670
Copy link
Contributor

This will close #4653

@jackwener jackwener mentioned this pull request Dec 16, 2022
Merged
@HaoYang670 HaoYang670 mentioned this pull request Dec 16, 2022
Closed
@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner labels Dec 16, 2022
HaoYang670
HaoYang670 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HaoYang670 HaoYang670 linked an issue Dec 16, 2022 that may be closed by this pull request
Wrongly use the function clamp #4654
Closed
@mingmwang
Copy link
Contributor

👍

@mingmwang
Copy link
Contributor

Waiting for this PR to get merged.

@Dandandan Dandandan merged commit 8504cb2 into apache:master Dec 16, 2022
@jackwener jackwener deleted the clippy branch December 16, 2022 10:00
@ursabot
Copy link

ursabot commented Dec 16, 2022

Benchmark runs are scheduled for baseline = 9667887 and contender = 8504cb2. 8504cb2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Dec 16, 2022

Thank you @jackwener

@alamb alamb mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoYang670 HaoYang670 HaoYang670 approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrongly use the function clamp Fix the clippy errors
6 participants
@jackwener @HaoYang670 @mingmwang @ursabot @alamb @Dandandan