-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace the arithmetic op for decimal array op decimal array using arrow kernel #4648
replace the arithmetic op for decimal array op decimal array using arrow kernel #4648
Conversation
@@ -503,9 +444,6 @@ mod tests { | |||
let left_decimal_array = create_decimal_array(&[Some(101)], 10, 1); | |||
let right_decimal_array = create_decimal_array(&[Some(0)], 1, 1); | |||
|
|||
let err = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this test removed as it is now covered by the new arithmetic_divide_zero
test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No,
The behavior of divide for decimal array with decimal array was changed.
In the previous implementation, we will check the 0 for dividend, but in the kernel divide_opt
of arrow-rs, the result will be None if the right is zero
From this changes, I find some inconsistent behavior for
The difference is from the arrow-rs kernel In the cc @alamb |
I recommend a ticket to fix the inconsistency upstream |
agree, ci failed with the clippy issue. |
Benchmark runs are scheduled for baseline = 09d3378 and contender = 30de028. 30de028 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4289
The behavior of divide for decimal array with decimal array was changed.
In the previous implementation, we will check the
0
for dividend, but in the kerneldivide_opt
of arrow-rs, the result will beNone
if the right iszero
cc @alamb
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?