Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LogicalPlanBuilder consuming (#4622) #4632

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Make LogicalPlanBuilder consuming (#4622) #4632

merged 1 commit into from
Dec 16, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Dec 14, 2022 •
edited
Loading

Which issue does this PR close?

Closes #4622

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner labels Dec 14, 2022
@tustvold tustvold force-pushed the make-logical-plan-builder-consuming branch 2 times, most recently from 836a0cf to b446e6d Compare December 14, 2022 22:50
@tustvold tustvold added the api change Changes the API exposed to users of the crate label Dec 14, 2022
@tustvold tustvold force-pushed the make-logical-plan-builder-consuming branch from b446e6d to 494d747 Compare December 15, 2022 08:09
@tustvold tustvold marked this pull request as ready for review December 15, 2022 08:10
@tustvold tustvold requested a review from alamb December 15, 2022 11:51
alamb
alamb approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you @tustvold

I really like the explicitness of clone() now -- I also think this will lead to less cloning overall in DataFusion

Baby 🦶 !

@tustvold tustvold merged commit 2e9eea4 into apache:master Dec 16, 2022
@ursabot
Copy link

ursabot commented Dec 16, 2022

Benchmark runs are scheduled for baseline = 8504cb2 and contender = 2e9eea4. 2e9eea4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make LogicalPlanBuilder Consuming
3 participants
@tustvold @ursabot @alamb