Remove Confusing "Bare" in does not exist messages #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Dec 9, 2022
| @@ -59,7 +59,7 @@ statement error Error during planning: table 'datafusion.public.users' not found | |||
| select * from users; | |||
|
|
|||
| # Can not drop it again | |||
| statement error Table Bare \{ table: "user" \} doesn't exist. | |||
| statement error Table 'user' doesn't exist. | |||
There was a problem hiding this comment.
You can see the result of the changes in this file ❤️
xudong963
approved these changes
Dec 10, 2022
|
This is a clear improvement, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4571
Rationale for this change
I think #4530 made error messages look much crappier. For example:
I noticed this while adding errors in #4535
I would like the messages to only have the table name (not the Debug version of OwnedTableReference).
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Better error messages